fix: clear errors while the overlay is loading - #1057
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Make compile/runtime error clearing effective while the overlay iframe is still loading.
Today both clear methods return when the iframe root is not ready. The pending load then renders an error that was already cleared. Runtime errors have a second path to the same result: the debounced callback retains the old error array and can recreate the overlay after clearing.
Implementation
Verification
mainand pass with this fix.Compatibility / breaking changes
No public API, dependency, socket integration, or supported-platform changes. Clearing errors now prevents an already-cleared pending overlay from appearing.