Skip to content

FIX / Handle group assignment on uninstall templates #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mary-Clb wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIX / Handle group assignment on uninstall templates #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
276603f
fix: handle group assignment on uninstall templates
Mary-Clb Apr 8, 2026
f0ceec0
use AssignableItemInterface
Mary-Clb Apr 8, 2026
d1cc5a5
update CHANGELOG.md
Mary-Clb Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Fix locales encoding
- Fix group assignment when applying uninstall templates on assignable items

## [2.10.3] - 2025-11-25

Expand Down
6 changes: 5 additions & 1 deletion inc/uninstall.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

use Glpi\Asset\Asset_PeripheralAsset;
use Glpi\Features\AssignableItemInterface;

use function Safe\preg_grep;

Expand Down Expand Up @@ -213,7 +214,10 @@ private static function doOneUninstall(PluginUninstallModel $model, Transfer $tr
}
}

if ($item->isField('groups_id')) {
if (
$item->isField('groups_id')
|| ($item instanceof AssignableItemInterface)
) {
$nbgroup = countElementsInTableForEntity(
"glpi_groups",
$entity,
Expand Down