Skip to content

[Fix]: A bug that was giving the possibility to link incompatibles container types and objects types - #1231

Open
jdurand-teclib wants to merge 7 commits into
pluginsGLPI:mainfrom
jdurand-teclib:fix/forbidden-link-between-some-types-and-subtypes
Open

[Fix]: A bug that was giving the possibility to link incompatibles container types and objects types#1231
jdurand-teclib wants to merge 7 commits into
pluginsGLPI:mainfrom
jdurand-teclib:fix/forbidden-link-between-some-types-and-subtypes

Conversation

@jdurand-teclib

@jdurand-teclib jdurand-teclib commented Jul 27, 2026

Copy link
Copy Markdown

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • This bug was discovered during investigation of ticket !45420. Not directly reported by the customer, but discovered by the team during the investigations.
  • What changes with this PR ?
    • It is no longer possible to link a container of type 'Insertion in the form of a specific tab' with any object that is compatible with it (i.e items not showed in the dedicated dropdown)
    • Fixes a display issue: when the form page was refreshed, the container type dropdown value was still the same, but the item type dropdown value was reseted, creating a mismatch of values.

@jdurand-teclib
jdurand-teclib requested a review from Rom1-B July 27, 2026 13:45
Comment thread CHANGELOG.md Outdated
Comment thread inc/container.class.php Outdated
Comment thread tests/Units/ContainerItemUpdateTest.php
jdurand-teclib and others added 3 commits July 27, 2026 16:38
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
@jdurand-teclib
jdurand-teclib requested a review from Rom1-B July 28, 2026 06:58
@Rom1-B

Rom1-B commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants