Skip to content

fix handle native glpi dropdown types when binding additional field to form destination #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 3 commits into from
Jul 27, 2026
Merged

fix handle native glpi dropdown types when binding additional field to form destination #1230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d4c0826
fix handle native glpi dropdown types when binding additional fields …
Herafia Jul 27, 2026
00db175
CHANGELOG + test
Herafia Jul 27, 2026
a05df29
Apply suggestion from @Rom1-B
Rom1-B Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

- Fix item creation with null value for mandatory fields
- Fix search crash when two containers share a dropdown field with the same name.
- Fix handle native GLPI dropdown types when binding additional fields to form destination

## [1.24.2] - 2026-06-30

Expand Down
4 changes: 2 additions & 2 deletions inc/destinationfield.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ public function applyConfiguratedValueToInputUsingAnswers(
if ($field->fields['type'] == 'glpi_item') {
$input[sprintf('itemtype_%s', $field_name)] = $answer->getRawAnswer()['itemtype'];
$input[sprintf('items_id_%s', $field_name)] = $answer->getRawAnswer()['items_id'];
} elseif ($field->fields['type'] == 'dropdown') {
$raw_id = (int) $answer->getRawAnswer()['items_id'];
} elseif (str_starts_with((string) $field->fields['type'], 'dropdown')) {
$raw_id = (int) ($answer->getRawAnswer()['items_id'] ?? 0);
$input[$field_name] = ($raw_id > 0) ? $raw_id : null;
} else {
$input[$field_name] = $value ?? $answer->getRawAnswer();
Expand Down
2 changes: 1 addition & 1 deletion inc/questiontype.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ public function formatRawAnswer(mixed $answer, Question $question): string

$names = [];
foreach ($answer as $items_id) {
$item = $itemtype::getById($items_id);
$item = $itemtype::getById((int) $items_id);
if ($item) {
$names[] = $item->fields['name'];
}
Expand Down
7 changes: 6 additions & 1 deletion tests/Units/FieldDestinationFieldTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,12 @@ public function testDestinationWithLocationAdditonalFields(): void
form: $form,
config: new SimpleValueConfig(1),
answers: [
"Location Field" => $location->getID(),
// The end user template submits dropdowns as an array
// containing the selected itemtype and items_id.
"Location Field" => [
'itemtype' => Location::class,
'items_id' => $location->getID(),
],
],
expected_field_values: [
Ticket::class => [
Expand Down