Skip to content

Fix - Avoid SQL warning when no user session is active during plugin init #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomainLvr wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

Fix - Avoid SQL warning when no user session is active during plugin init #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b882743
Fix - Avoid SQL warning when no user session is active during plugin …
RomainLvr Apr 13, 2026
ecf1c25
Update CHANGELOG
RomainLvr Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

### Fixed

- Fix SQL warning when no user session is active during plugin init
- Fix error when submitting a form with an hidden question of type `Field`
- Fixed a bug where a field was deleted when at least one question in a form was linked to another field

Expand Down
2 changes: 1 addition & 1 deletion inc/questiontype.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ private function getAvailableBlocks(): array
$field_container = new PluginFieldsContainer();
$available_blocks = [];

$entity_restrict = isCommandLine() ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true);
$entity_restrict = (isCommandLine() || !Session::getLoginUserID()) ? [] : getEntitiesRestrictCriteria(PluginFieldsContainer::getTable(), '', '', true);
Copy link
Copy Markdown
Contributor

@Rom1-B Rom1-B Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, you're either in CLI mode or logged in as an authenticated user. It seems to be neither, so I don't think this should be allowed, to avoid creating a security issue

$result = $field_container->find([
'is_active' => 1,
'type' => 'dom',
Expand Down