Skip to content

ci: reinstate fsspec license check - #294

Merged
toby-coleman merged 2 commits into
mainfrom
copilot/reinstate-license-check-fsspec
Sep 23, 2026
Merged

toby-coleman merged 2 commits into
mainfrom
copilot/reinstate-license-check-fsspec

Conversation

Copilot AI commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The project was temporarily excluding fsspec from the license audit while upstream packaging metadata was missing a reported license. That issue is resolved, so the CI check can be restored without weakening the project’s open-source compliance gate.

Changes

  • Removed the temporary fsspec exclusion from the GitHub Actions license-check step.
  • Removed the ignore_packages = ["fsspec"] override from pyproject.toml.
  • Restored the standard dependency license validation for the current fsspec release without changing application behavior.

Co-authored-by: toby-coleman <13170610+toby-coleman@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown

Benchmark comparison for 3817b9c7 (base) vs 78050edf (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.14-64bit/0001_pr)         399.4938 (1.0)      405.9550 (1.0)      402.7513 (1.0)      2.4038 (1.0)      402.3356 (1.0)      3.0983 (1.0)           2;0  2.4829 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.14-64bit/0001_base)     403.0824 (1.01)     416.7689 (1.03)     407.8421 (1.01)     5.2196 (2.17)     406.7570 (1.01)     4.3134 (1.39)          1;1  2.4519 (0.99)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Copilot AI changed the title [WIP] Reinstate license check on fsspec ci: reinstate fsspec license check Sep 23, 2026
Copilot AI requested a review from toby-coleman September 23, 2026 21:03
@github-actions

Copy link
Copy Markdown

Benchmark comparison for 3817b9c7 (base) vs ff2fa2d0 (PR)


------------------------------------------------------------------------------------------------------------------ benchmark: 2 tests -----------------------------------------------------------------------------------------------------------------
Name (time in ms)                                                                         Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_benchmark_process_run (pr/.benchmarks/Linux-CPython-3.14-64bit/0001_pr)         542.7299 (1.0)      552.6072 (1.0)      547.6739 (1.0)      3.9211 (1.0)      547.3395 (1.0)      6.2265 (1.0)           2;0  1.8259 (1.0)           5           1
test_benchmark_process_run (main/.benchmarks/Linux-CPython-3.14-64bit/0001_base)     547.8373 (1.01)     559.6520 (1.01)     552.6518 (1.01)     4.8057 (1.23)     550.2469 (1.01)     6.9772 (1.12)          2;0  1.8095 (0.99)          5           1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@toby-coleman
toby-coleman marked this pull request as ready for review September 23, 2026 21:08
@toby-coleman
toby-coleman merged commit 894671b into main Sep 23, 2026
27 checks passed
@toby-coleman
toby-coleman deleted the copilot/reinstate-license-check-fsspec branch September 23, 2026 21:14
@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Reinstate license check on fsspec

2 participants