Repository navigation
fix: Update choreographer and rely on its message chunking - #478
Merged
Merged
Conversation
KoolADE85
previously approved these changes
Oct 5, 2026
There was a problem hiding this comment.
It looks like we're missing a test here for #467 (integers > 2**64). I confirmed manually that it works, but would be good to have a test for it.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll add a test.
| @@ -40,7 +37,7 @@ | |||
|
|
|||
| # union of sized iterables since 3.8 doesn't have & operator | |||
Contributor
Author
There was a problem hiding this comment.
I'll update the comment to make it clearer. The Listish is still needed.
camdecoster
commented
Oct 6, 2026
camdecoster
left a comment
Contributor
Author
There was a problem hiding this comment.
I'll make the next release a patch or minor bump since 3.8 is so old that no one should still be using it.
| @@ -40,7 +37,7 @@ | |||
|
|
|||
| # union of sized iterables since 3.8 doesn't have & operator | |||
Contributor
Author
There was a problem hiding this comment.
I'll update the comment to make it clearer. The Listish is still needed.
Contributor
Author
There was a problem hiding this comment.
Good point. I'll add a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update choreographer to v1.4.0 and rely on its message chunking. Remove the chunking code added in #442 (and the problematic serialization).
Closes #343.
Closes #423.
Closes #465.
Closes #467.
Changes
Testing
pd.NaTandpd.NAvaluesNotes