Skip to content

Update/dash avs explorer - #806

Open
budescode wants to merge 2 commits into
plotly:mainfrom
budescode:update/dash-avs-explorer
Open

Update/dash avs explorer#806
budescode wants to merge 2 commits into
plotly:mainfrom
budescode:update/dash-avs-explorer

Conversation

@budescode

Copy link
Copy Markdown

Issue for app: none (dependency update, no linked issue)

App pull request

  • This is a new app
  • I am improving an existing app (redesigns/code "makeovers")

About

Updates dash-avs-explorer to current package versions, makes it installable
with uv or pip from a fresh clone, and restores the KITTI dataset, whose
data source is not available.

  • Declare the direct dependencies in pyproject.toml and lock with uv
  • Declare the local dash_avs_ui-0.0.1.tar.gz as a path source, since the component was never published to PyPI
  • Regenerate requirements.txt from uv.lock so pip users still work
  • Pin dash 4.4.1, dash-bootstrap-components 2.0.4 and gunicorn 26.2.0, none of which had a version before
  • Require Python 3.12 or newer; raise runtime.txt from 3.7.6 to 3.12.11
  • Replace dash_core_components and dash_html_components imports with from dash import dcc, html
  • Replace app.run_server with app.run
  • Replace dbc.FormGroup, removed in dash-bootstrap-components 1.0, with html.Div
  • Point the KITTI dataset at uber/xviz-data; the plotly/xviz-data-kitti repository no longer exists, so the default view was loading nothing
  • Disable the three KITTI scenes whose data is no longer hosted anywhere and default to drive 0005, the one that is
  • Add uv install and run instructions to the README and update its Python version

The dash_avs_ui component itself is unchanged. Its 2020 build mounts
correctly under Dash 4.

Verified in a headless browser on Python 3.12: the page loads with no Dash
error and no failed requests, the unavailable scenes show as disabled
with drive 0005 selected, and the 3D viewer mounts and fetches its
frames.

Workflow

  • I have created a branch in the appropriate monorepo, and the
    elements necessary for successful deployment are in place.
  • If the app is a redesigned and/or restyled version of an
    existing gallery app, I've summarized the changes requested in the
    appropriate Streambed issue and confirm that they have been applied.
  • If the app is on the Dash Gallery portal, I have added a link to
    the GitHub repository for the source code in the portal description.
  • If the app is a reimplementation of a Python gallery app for the
    DashR gallery, the app in this PR mimics, as closely as possible,
    the style and functionality of the existing app.
  • I have removed all Google Analytics code from the app's
    assets/ folder.

The pre-review review

I have addressed all of the following questions:

  • Does everything in my code serve some purpose? (I have removed
    any dead and/or irrelevant code.)
  • Does everything in my code have a clear purpose? (My code is
    readable and, where it isn't, it has been commented appropriately.)
  • Am I reinventing the wheel? (I have used appropriate packages to
    lessen the volume of code that needs to be maintained.)

Post PR (at merge time)

  • When you are merging, make sure to write one of the following tags in the commit message (or it will default to patch):
    • #patch - An app has been updated or fixed
    • #minor - A new app has been added, or an app has been significantly reworked
    • #major - Breaking changes, make sure to discuss with dash-core before using this tag

- Declare the local dash_avs_ui-0.0.1.tar.gz as a path source, since the component was never published to PyPI
- Regenerate requirements.txt from uv.lock so pip users still work
- Pin dash 4.4.1, dash-bootstrap-components 2.0.4 and gunicorn 26.2.0, none of which had a version before
- Require Python 3.12 or newer; raise runtime.txt from 3.7.6 to 3.12.11
- Replace dash_core_components and dash_html_components imports with from dash import dcc, html
- Replace app.run_server with app.run
- Replace dbc.FormGroup, removed in dash-bootstrap-components 1.0, with html.Div
- Point the KITTI dataset at uber/xviz-data; the plotly/xviz-data-kitti repository no longer exists
- Disable the KITTI scenes whose data is no longer hosted and default to drive 0005, the one that is
- Add uv install and run instructions to the README and update its Python version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant