Update/dash aerosandbox - #803
Open
budescode wants to merge 3 commits into
Open
Conversation
Declare the nine direct dependencies in pyproject.toml, lock with uv and regenerate requirements.txt from uv.lock so pip users still work. Bump dash 1.9 -> 4.4.1, dash-bootstrap-components 0.8.0 -> 2.0.4, plotly 4.6.0 -> 7.0.0, numpy 1.18 -> 2.5.2 and pin pandas 3.0.5, seaborn 0.13.2 and gunicorn 26.2.0. Python 3.12 or newer is required; raise runtime.txt from 3.7.6 to 3.12.11. aerosandbox stays at 1.1.20 Drop dash_core_components and dash_html_components, merged into dash, and importlib-resources, a Python 3.7 backport.
- Import html and dcc from dash. - Replace app.run_server with app.run - Replace the n_clicks_timestamp inputs, which dbc.Button no longer accepts, with n_clicks - Use dash.ctx.triggered_id to tell which button was pressed.
Author
|
@robertclaus Please can you review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for app: none (dependency update, no linked issue)
App pull request
About
Update dash-aerosandbox from its 2020 dependencies to current versions and
makes it installable with uv or pip from a fresh clone.
regenerates requirements.txt from uv.lock.
runtime.txt raised from 3.7.6 to 3.12.11.
plotly 4.6.0 -> 7.0.0, numpy 1.18 -> 2.5.2, and pins pandas 3.0.5,
seaborn 0.13.2 and gunicorn 26.2.0.
Casll1,Casvlm1or thee216airfoil the app is built on, so moving forwardwould mean rewriting the aerodynamics code.
and importlib-resources, a Python 3.7 backport.
from dash import dcc, html,app.run, anddash.ctx.triggered_idin place of theremoved
n_clicks_timestampbutton property.Verified on Python 3.12 and 3.13: the geometry view, the LL analysis and
the VLM analysis all run and produce the same figures and tables as
before.
Workflow
elements necessary for successful deployment are in place.
existing gallery app, I've summarized the changes requested in the
appropriate Streambed issue and confirm that they have been applied.
the GitHub repository for the source code in the portal description.
DashR gallery, the app in this PR mimics, as closely as possible,
the style and functionality of the existing app.
assets/folder.The pre-review review
I have addressed all of the following questions:
any dead and/or irrelevant code.)
readable and, where it isn't, it has been commented appropriately.)
lessen the volume of code that needs to be maintained.)
Post PR (at merge time)
#patch- An app has been updated or fixed#minor- A new app has been added, or an app has been significantly reworked#major- Breaking changes, make sure to discuss with dash-core before using this tag