chore: add playwright and screenshot tests for examples#1465
Merged
crutchcorn merged 2 commits intomainfrom Jan 5, 2026
Merged
chore: add playwright and screenshot tests for examples#1465crutchcorn merged 2 commits intomainfrom
crutchcorn merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
20jasper
force-pushed
the
add-playwright
branch
4 times, most recently
from
e5a3c95 to
8c603e4
Compare
20jasper
force-pushed
the
add-playwright
branch
2 times, most recently
from
ba1eece to
d7d09f9
Compare
Merged
crutchcorn
approved these changes
Jan 5, 2026
crutchcorn
added a commit
that referenced
this pull request
Jan 5, 2026
Merge #1465 first - adds separate node and browser configs for vitest - browser tests are called `*.ui.spec.{ts,tsx}` and node tests are called `*.node.spec.ts` - adds a helper to run MSW in browser tests as per MSW docs recommendation - I made an eslint rule to enforce using the helper in browser unit tests - fixes a data race where stale tag counts were displayed - upgrades to vitest v4 Browser unit tests use Firefox for no particular reason over any other browser. I'm glad to run webkit and chrome in unit tests as well if anyone feels strongly about it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds playwright and full size snapshot tests in light and dark mode for the example blog. This should enforce baseline styles for most markdown components
I initially went with a text diff of the HTML, but there is so much astro dev info injected that it wouldn't be easy to read
Playwright screenshots are used instead of Vitest's since it avoids a decent bit of manual setup and large screenshots are grainy for vitest