Port from deprecated herdr-browser to terminal-browser - #1
Open
punk-dev-robot wants to merge 1 commit into
Open
Conversation
herdr-browser (official.browser) was deprecated in favor of the terminal-browser CLI, which ships its own thin Herdr plugin. Present now runs 'terminal-browser open <url> --split right' against the requesting pane, maps the opened browser to its Herdr pane via 'ls --json', and zooms it; dismiss closes the pane. The presenter stdin protocol is unchanged. Runtime discovery resolves the terminal-browser executable instead of inspecting a plugin root; the integration config schema is now 3 and records it. A 13-second overall deadline keeps present inside Plannotator's 15-second budget, and doctor probes the resolved binary with --version. Requires Herdr 0.8.2, matching terminal-browser's own floor.
|
@backnotprop pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Port from the deprecated herdr-browser plugin to the terminal-browser CLI, which replaced it as Herdr's browser surface.
terminal-browser open <url> --split rightagainst the requesting pane (HERDR_PANE_IDpinned in the child env), map the opened browser to its Herdr pane viaterminal-browser ls --json(retried briefly), best-effortherdr pane zoom --onto keep the previous zoomed presentationherdr pane close <paneId>, idempotent onpane_not_found~/.local/bin) instead of inspecting theofficial.browserplugin rootAbortSignalkeeps the present flow inside Plannotator's 15s presentation budget even in worst-case timeout stacking--versioninstead of only reporting a pathterminalBrowserBin); re-runconfigureafter upgradingherdr pane splitinternally)The presenter stdin protocol is unchanged (protocol 1,
present/dismiss,handle={paneId}).Validation
bun test(33) andtsc --noEmitcleanbin/herdr-plannotator-present,configure+doctoractions green, pane opens zoomed and closes cleanlyContext
Ready for Plannotator's external presenter support (backnotprop/plannotator#1147) — verified end-to-end against this helper. Interim users can bridge with a
BROWSER/PLANNOTATOR_BROWSERwrapper script until that lands (note: backnotprop/plannotator#1391 affectsPLANNOTATOR_BROWSERscript paths on macOS via the pi extension).