Skip to content

Stop direct VStream at target VGTID - #93

Open
nickvanw wants to merge 1 commit into
mainfrom
fix-direct-vstream-stop-boundary
Open

Stop direct VStream at target VGTID#93
nickvanw wants to merge 1 commit into
mainfrom
fix-direct-vstream-stop-boundary

Conversation

@nickvanw

Copy link
Copy Markdown
Contributor

Summary

  • stop direct VStream reads as soon as the requested target VGTID is reached
  • keep the early-stop path disabled for historical-copy/copy-resume cursors
  • add regression coverage that fails if sync waits for a later VGTID after receiving the target commit VGTID

Tests

  • env GOCACHE=/tmp/go-build go test ./lib
  • env GOCACHE=/tmp/go-build go test ./...
  • env GOCACHE=/tmp/go-build go test ./lib -run 'TestSync_DirectVStreamStopsAtTargetVGTIDWithoutWaitingForLaterEvent|TestRead_CanStopAtWellKnownCursor|TestSync_CheckpointsHistoricalCopyProgress|TestSync_DoesNotPeriodicallyCheckpointVGTIDProgress|TestRead_ResumesHistoricalCopyEvenWhenPeekMatchesCopyCursorPosition|TestRead_DoesNotStopAfterProgressingTimeoutWindows' -count=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant