Skip to content

Add MoveTables list and lifecycle guidance - #1408

Open
no-itsbackpack wants to merge 4 commits into
mainfrom
egomez/move-tables-list-next-steps
Open

no-itsbackpack wants to merge 4 commits into
mainfrom
egomez/move-tables-list-next-steps

Conversation

@no-itsbackpack

@no-itsbackpack no-itsbackpack commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

pscale branch vtctld move-tables list lists the workflows on a branch, and MoveTables and VDiff commands now return a next_steps field telling an agent what to run next based on the workflow's actual state, so it can drive a migration to completion without guessing the order.

{
  "traffic_state": "All Reads Switched. Writes Not Switched",
  "next_steps": [
    {
      "command": "pscale branch vtctld move-tables switch-traffic mydb main --org acme --workflow commerce2customer --target-keyspace customer --tablet-types PRIMARY --format json",
      "reason": "Switch primary traffic after validating replica traffic"
    }
  ]
}

Guidance follows the Vitess lifecycle: wait while copying, VDiff once streams are running, switch replica then primary traffic, preview cleanup with complete --dry-run. Destructive complete and cancel are never suggested outright, and a VDiff mismatch returns a reason with no command so an agent stops instead of switching traffic over bad data.

next_steps is added to the existing response without altering the fields or ordering the API returns.

no-itsbackpack and others added 4 commits September 14, 2026 17:36
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@no-itsbackpack
no-itsbackpack marked this pull request as ready for review September 14, 2026 23:42
@no-itsbackpack
no-itsbackpack requested a review from a team as a code owner September 14, 2026 23:42

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 59b1597. Configure here.

Comment thread internal/planetscale/vtctld_move_tables.go

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Left a non-blocking comment and did not approve: Cursor Bugbot completed with one unresolved high-severity finding on MoveTables list JSON handling. Human review is needed.

Open in Web View Automation 

Sent by Cursor Approval Agent: cli-reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants