Add vtctld set-shard-tablet-control command#1268
Draft
maxenglander wants to merge 4 commits into
Draft
Conversation
c523aef to
baa7d16
Compare
46fc1f8 to
56e07e2
Compare
baa7d16 to
35ab8e7
Compare
56e07e2 to
6f69901
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 27c1ed7. Configure here.
|
|
||
| client, err := ch.Client() | ||
| if err != nil { | ||
| return err |
There was a problem hiding this comment.
Missing mutation flag validation
Medium Severity
The command reads remove and disable-query-service via Flags().Changed but never requires at least one of --remove, --denied-tables, or --disable-query-service before calling the API. The PR describes that check and manual “CLI validation,” yet no matching fmt.Errorf exists in this repo (unlike deployrequest edit).
Reviewed by Cursor Bugbot for commit 27c1ed7. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
35ab8e7 to
d76a790
Compare
27c1ed7 to
fc3b72f
Compare
Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Max Englander <max@planetscale.com>
3a7e5c9 to
4c2996a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a hidden vtctld command to update shard tablet controls on the cluster:
Requires at least one of
--remove,--denied-tables, or--disable-query-service.Depends on planetscale/planetscale-go#315.
Manual testing
Tested end-to-end against a dev Vitess branch (org with
direct_vtctld_accessenabled) with the full stack deployed.get-shardon unsharded keyspacetest-vtctld/-returned emptytablet_controls.{}. Re-ranget-shardand confirmed:{ "tablet_controls": [ { "tablet_type": 3, "cells": [], "denied_tables": ["customers"], "frozen": false } ] }get-shardthen showed emptytablet_controlsagain.must specify at least one of --remove, --denied-tables, or --disable-query-service.sharded-2/-80with--denied-tables orders— same behavior.