Fix Derby compatibility in metadata DAOs - #1402
Open
xiaotongsaying wants to merge 1 commit into
Open
Conversation
Remove MySQL-specific identifier quoting from metadata DAO queries. Use JDBC generated keys instead of LAST_INSERT_ID(). Add the default Derby JDBC driver configuration. Update fresh installations to use PIXELS_HOME for Derby and var paths. Adjust the affected DAO test for generated-key retrieval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MySQL-specific identifier quoting from metadata DAO queries. Use JDBC generated keys instead of LAST_INSERT_ID(). Add the default Derby JDBC driver configuration.
Update fresh installations to use PIXELS_HOME for Derby and var paths. Adjust the affected DAO test for generated-key retrieval.
What does this PR do?
This PR improves Derby compatibility in the metadata DAO implementation while
preserving MySQL support.
Changes
SELECT LAST_INSERT_ID()with JDBCRETURN_GENERATED_KEYS.directories under
PIXELS_HOME.Why is this needed?
The default metadata database is Derby, but some DAO statements still use
MySQL-specific SQL syntax. These statements can fail when metadata operations
are executed against Derby.
Testing
Tested on:
Verified the following flow:
INIT-META.regiontable through the Pixels Trino connector.region.tblfile with pixels-cli..pxlfile was generated.Query: