fix: forward svgExportRenderer from the starter route - #3
Open
Sokanon wants to merge 1 commit into
Open
Conversation
ToolcraftApp accepts svgExportRenderer and the export docs tell products to provide it for a typed export-svg action, but the starter route never passed it through, so a generated app could not mount the documented SVG export path at all. The route now forwards it like every other composition prop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolcraftAppacceptssvgExportRenderer, anddocs/toolcraft/core/setup-export.mdtells products to declare a typedexport-svgaction and provideToolcraftAppComposition.svgExportRenderer. The starter'ssrc/routes/index.tsxforwards every other composition prop but not that one, so a generated app cannot mount the documented SVG export path: the output-export contract requires the renderer for a typed SVG action, and the route is framework-owned, so the app can't patch it locally without failing the integrity check.Change
One line in
starter/src/routes/index.tsx: passsvgExportRenderer={appComposition.svgExportRenderer}alongside the other props.Verified
tsc --noEmiton the starter is green with the change. Hit this while building a pattern tool on the starter that needed a vector export.