Conversation
Signed-off-by: Norway-02 <anshulkhetade02@gmail.com>
Author
|
cc @mohammedfirdouss @Warashi @armistcxy - Please review when you get a chance. Thanks! |
✅ Deploy Preview for pipecd-site ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checks item expiration in
TTLCache.Get()and evicts expired entries as cache misses (cache.ErrNotFound), instead of solely relying on the background evicter ticker.Why we need it:
Previously,
TTLCache.Get()did not verify whether an entry's expiration time had passed. If an entry expired between background eviction ticks (or if the cache was instantiated withevictionInterval <= 0),Get()would return the expired item as a valid cache hit. In security-sensitive components likeencryptionKeyCache,apiKeyCache, andrbacCache, serving expired cache hits can result in stale encryption keys or outdated authorization state.Which issue(s) this PR fixes:
Fixes # NONE
Does this PR introduce a user-facing change?:
Screenshots/Videos (for documentation or website changes):
N/A