fix(web): prevent active stage selection from being overridden on pol… - #7121
Open
kunaldevsahu wants to merge 1 commit into
Open
fix(web): prevent active stage selection from being overridden on pol…#7121kunaldevsahu wants to merge 1 commit into
kunaldevsahu wants to merge 1 commit into
Conversation
kunaldevsahu
requested review from
Warashi,
hongky-1994,
khanhtc1202 and
t-kikuc
August 4, 2026 07:55
Contributor
|
👋 Hi @kunaldevsahu, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue in the Deployment Details page where the selected stage was reset during live polling.
The implementation introduces intelligent default stage tracking using a React
useRefto distinguish between users who are following the default active stage and users who have manually selected a different stage. This preserves manual stage selections while still allowing the UI to automatically advance when the user is following the deployment's default progression.Why we need it
The deployment details page polls for updates every 4 seconds while a deployment is running. Each polling update refreshes the deployment object, causing the initialization effect to run repeatedly and reset the selected stage to the default active stage.
As a result, users are unable to inspect logs or details of another stage because their selection is overwritten on every polling cycle.
With this change:
Which issue(s) this PR fixes
Fixes #7119
Does this PR introduce a user-facing change?
Yes
How are users affected by this change?
Users can inspect logs and details for any stage on the Deployment Details page without their selection being reset during live polling.
Is this a breaking change?
No.
How to migrate (if breaking change)
N/A.