Add GraphQLTSPDenormalizer to GraphQL Emitter#32
Draft
FionaBronwen wants to merge 4 commits intofeature/graphqlfrom
Draft
Add GraphQLTSPDenormalizer to GraphQL Emitter#32FionaBronwen wants to merge 4 commits intofeature/graphqlfrom
FionaBronwen wants to merge 4 commits intofeature/graphqlfrom
Conversation
steverice
reviewed
Jul 11, 2025
There was a problem hiding this comment.
I think this is a classic visitor pattern problem.
We should define a series of denormalizations as visitors that can be applied to the TypeSpec program.
TypeSpec is already essentially structured for this using navigateProgram and friends.
But I'm not 100% sure how this interacts with TypeKit, so let me know if I am missing something there cc @swatkatz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new
GraphQLTSPDenormalizerclass that is responsible for handling the denormalization of a TSP namespace for GraphQL purposes. TheGraphQLTSPDenormalizeris essentially a preprocessing step that transforms the TypeSpec types into a more GraphQL friendly shape.The resulting TypeSpec denormalized for GraphQL can then be used as input for multiple different emitters that are related to GraphQL for example:
This unified denormalization approach allows us to reuse transformation logic and ensure consistency across emitters working in the same domain (in our case GraphQL).
This PR focuses on only the first denormalization step, creating input specific types for models used as inputs to operations.
Example
TypeSpec Input
TypeSpec Output
Following Work
The following GraphQL normalization steps will be addressed subsequently: