Refactor server diagnostics with Effect-native APIs#4156
Draft
cursor[bot] wants to merge 3 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
fs/promisesandEffect.tryPromisein workspace file reads with the injected EffectFileSystem, scoped handles,FileSystem.Size, andOption.JSON.parse/record traversal withSchema.fromJsonString, per-record Schema decoding, andOptionnormalization.Why
These paths now stay inside Effect APIs end-to-end, making filesystem behavior layer-testable and process payload parsing typed and explicit while preserving existing behavior.
Checklist
Note
Refactor server diagnostics and workspace file reading to use Effect-native APIs
parseWindowsProcessRowsin ProcessDiagnostics.ts to useSchema-based decoding, skipping invalid records and returning[]for malformed JSON. The function is now exported.readFilein WorkspaceFileSystem.ts to use the EffectFileSystemservice forrealPath,open,stat, andreadAlloc, replacing directnode:fs/promisescalls.readFileerror causes are nowPlatformErrorvalues instead ofNodeJS.ErrnoException; resource management is scoped rather than manual close.Macroscope summarized a47c24e.