Add right panel close controls

[caezium]

What Changed

• Add an explicit close button as the right-most control in the inline right-panel title-bar cluster.
• Add a configurable rightPanel.closeActiveSurface command, bound to Cmd+W/Ctrl+W while focus is inside the right panel.
• Route the macOS native Close Window accelerator through a stable renderer listener so any active right-panel tab closes before the app window, including terminal and preview cases where DOM focus reports the page root.
• Preserve browser/editor-style middle-click closing for right-panel surface tabs, with regression coverage proving only button 1 closes the selected tab.
• Harden focus ownership across preview webviews and pointer-driven focus transitions, and keep the close-surface shortcut disabled while the right panel is closed.
• Add focused coverage for panel focus detection, shortcut precedence, close-request routing, menu dispatch, title-bar control ordering, and middle-click tab closing.

Why

The right panel has per-tab close actions but no obvious way to hide the whole panel. On macOS, Cmd+W also reaches Electron's native Close Window action instead of closing the active side-panel tab. Right-panel tabs also follow the familiar browser/editor convention: middle-click closes the selected tab without closing the panel or app window.

Closes #4146.
Closes #4147.

UI Changes

Before

After

Interaction

Cmd+W / whole-panel close

Watch the last active tab close and the panel reopen

The Cmd+W clip starts with one Files tab, so closing the last tab hides the panel; the panel toggle then reopens it.

Middle-click tab close

Watch middle-click close Files while Terminal and the app window stay open

This clip uses an isolated Close controls demo fixture and contains no private workspace content.

Validation

• bun x vp test run apps/web/src/components/RightPanelTabs.test.tsx (5 tests passed)
• bun x vp test run apps/web/src/lib/rightPanelFocus.test.ts apps/web/src/lib/nativeCloseFocus.test.ts apps/web/src/lib/rightPanelCloseRequest.test.ts apps/web/src/components/RightPanelTabs.test.tsx (4 files, 33 tests passed)
• Targeted lint for all touched web files (passes)
• bun run --cwd apps/web typecheck (passes)
• Real Electron dev app: the far-right X closes the whole right panel and the panel toggle reopens it.
• Real Electron dev app: invoking the native File → Close Window action with Files open closes the Files surface and leaves the app window open, even when accessibility focus reports only the page root.
• Real Electron dev app: middle-clicking an inactive Files tab closes only Files while Terminal, the right panel, and the app window stay open.
• bun x vp check (passes with 10 existing warnings in unrelated files)
• bun x vp run typecheck (passes across all 15 workspaces)

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Note

Medium Risk
Changes macOS window-close and Cmd+W behavior across Electron menus and renderer focus heuristics; mistakes could close the wrong layer or skip native close fallbacks.

Overview
Adds whole-panel and surface-level close for the inline right panel: a title-bar Close control, rightPanel.closeActiveSurface (Cmd/Ctrl+W when the right panel has focus and no terminal is focused), and middle-click to close a tab via shared handleSurfaceTabAuxClick.

On macOS desktop, File → Close Window no longer uses the native close role alone. It sends close-window-or-right-panel to the main renderer when possible (dispatchMenuActionToMainWindow), otherwise performClose: through new ElectronMenu.sendActionToFirstResponder. The renderer uses nativeCloseFocus and resolveNativeCloseTarget so close hits drawer terminals, right-panel terminals/surfaces, or the panel before the window—even when DOM focus is wrong (e.g. preview webviews).

AppSidebarLayout handles the menu action by dispatching a cancelable close event; unhandled closes call window.close(). ChatView defers macOS Cmd+W to the menu path when appropriate and wires shortcut handling for layered closes.

^{Reviewed by Cursor Bugbot for commit 4935f60. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add right panel close controls with Cmd+W routing on macOS

• Adds a RightPanelCloseControl UI button and rightPanel.closeActiveSurface keybinding (Cmd+W when the right panel owns focus and no terminal is focused) to close the active right-panel surface.
• On macOS, replaces the File menu's native close role with a custom 'Close Window' item that first tries to route close-window-or-right-panel to the renderer; if unhandled, falls back to the native performClose: action via ElectronMenu.sendActionToFirstResponder.
• Adds nativeCloseFocus tracking to determine which UI region (drawer terminal, right-panel terminal, or right-panel chrome) should handle a native close request based on recent focus and pointer activity.
• Adds DesktopWindow.dispatchMenuActionToMainWindow to send menu actions only to the registered main window without revealing it, returning whether the action was handled.
• Behavioral Change: Cmd+W on macOS in the desktop app is now intercepted by the renderer when the right panel owns focus, closing the active surface before the window.

^{Macroscope summarized 4935f60.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 18c0ce37-5013-4e64-849f-a5df0148b315

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR introduces a new feature (right panel close controls with Cmd+W keybinding) involving complex focus tracking state, Electron/renderer coordination, and multiple new logic files. Additionally, an open review comment identifies a potential bug in the blur/focus handling for webviews.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

what is the interaction demo doing? looks like you're just toggling visibility which you can already do with Mod+Shift+B ?

[caezium]

pressing cmd+w to close a single panel, since in the vid there was only one, the whole panel closed, sorry for the bad video, ill record another one

[caezium]

Updated the PR description with a separate real-app middle-click demo. It starts with Files and Terminal open, then middle-click closes only Files while Terminal, the right panel, and the app window stay open. I also added focused regression coverage for button 1 and clarified what the existing Cmd+W clip is showing.

[caezium]

Follow-up review fix in 85e780f: hosted preview focus is now matched by tab ID against the active right-panel preview, so a standalone preview cannot trigger the right-panel close shortcut. The focused tests cover matching and mismatched preview IDs.

[cursor]

Blur ends pointer focus guard early

Medium Severity

recordNativeClosePointer no longer ends the pointer transition on a microtask, and ChatView now calls finishNativeClosePointer on window blur. Electron webview focus often emits blur/focus around the click while activeElement still looks like the page root. Ending pointerTransitionActive before that click’s focusout lets recordNativeCloseFocusOut clear retainedOwner whenever document.hasFocus() is still true, so native Cmd+W can fall through to closing the window instead of the preview surface.

Additional Locations (1)

• apps/web/src/lib/nativeCloseFocus.ts#L27-L50

 

^{Reviewed by Cursor Bugbot for commit 85e780f. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4935f60. Configure here.}

[cursor]

Native close ignores preview tab match

Medium Severity

The ownerForElement function incorrectly assigns right-panel ownership to any focused webview or [data-preview-viewport] without checking if it's the active right-panel preview. This allows the macOS Cmd+W shortcut to close the active right-panel surface when an inactive preview is focused, bypassing existing tab ID checks.

 

^{Reviewed by Cursor Bugbot for commit 4935f60. Configure here.}