Skip to content

feat(packaging): add deb and rpm desktop targets#4069

Open
bigpod98 wants to merge 4 commits into
pingdotgg:mainfrom
bigpod98:main
Open

feat(packaging): add deb and rpm desktop targets#4069
bigpod98 wants to merge 4 commits into
pingdotgg:mainfrom
bigpod98:main

Conversation

@bigpod98

@bigpod98 bigpod98 commented Jul 17, 2026

Copy link
Copy Markdown

What Changed

Added additional outputs to packaging script.

Why

Allows output of 2 linux packaging systems Deb and RPM
issue #4030

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Packaging and metadata-only changes to the build script with tests; no runtime app or auth logic touched.

Overview
Adds Linux .deb and .rpm packaging entry points via dist:desktop:deb and dist:desktop:rpm, writing artifacts to packaging-output/ (also gitignored).

The desktop artifact script now sets electron-builder Linux distribution fields (maintainer, vendor, synopsis, syncDesktopName) for all Linux targets, and when the target is deb, declares explicit deb.depends on common GTK/NSS/secret/audio libraries. The staged build package.json picks up richer product metadata (homepage, license, desktopName, description, author email) so package managers get proper labels.

Coverage includes a unit test asserting deb Linux config and dependency list.

Reviewed by Cursor Bugbot for commit 6f2eac5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add deb and rpm npm build scripts for Linux desktop packaging

  • Adds dist:desktop:deb and dist:desktop:rpm npm scripts in package.json that invoke scripts/build-desktop-artifact.ts for x64 Linux builds, outputting to packaging-output/.
  • Linux build configs now include maintainer, vendor, synopsis, and syncDesktopName. For deb targets, a deb.depends list is set covering GTK, NSS, libsecret, and other required system libraries.
  • The staged package.json used during builds is updated with homepage, license, desktopName, a richer description, and author email.

Macroscope summarized 6f2eac5.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2518e29a-f37c-4a03-99a9-daace2f8cd66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 17, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 17, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Build/packaging configuration only - adds Linux deb/rpm package metadata and dependencies with no runtime behavior changes. Test coverage included for the new configuration.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp
macroscopeapp Bot dismissed their stale review July 17, 2026 01:36

Dismissing prior approval to re-evaluate 03b684c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants