feat(packaging): add deb and rpm desktop targets#4069
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Build/packaging configuration only - adds Linux deb/rpm package metadata and dependencies with no runtime behavior changes. Test coverage included for the new configuration. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate 03b684c
What Changed
Added additional outputs to packaging script.
Why
Allows output of 2 linux packaging systems Deb and RPM
issue #4030
Checklist
Note
Low Risk
Packaging and metadata-only changes to the build script with tests; no runtime app or auth logic touched.
Overview
Adds Linux
.deband.rpmpackaging entry points viadist:desktop:debanddist:desktop:rpm, writing artifacts topackaging-output/(also gitignored).The desktop artifact script now sets electron-builder Linux distribution fields (maintainer, vendor, synopsis,
syncDesktopName) for all Linux targets, and when the target isdeb, declares explicitdeb.dependson common GTK/NSS/secret/audio libraries. The staged buildpackage.jsonpicks up richer product metadata (homepage,license,desktopName, description, author email) so package managers get proper labels.Coverage includes a unit test asserting deb Linux config and dependency list.
Reviewed by Cursor Bugbot for commit 6f2eac5. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add
debandrpmnpm build scripts for Linux desktop packagingdist:desktop:debanddist:desktop:rpmnpm scripts in package.json that invoke scripts/build-desktop-artifact.ts for x64 Linux builds, outputting topackaging-output/.syncDesktopName. Fordebtargets, adeb.dependslist is set covering GTK, NSS, libsecret, and other required system libraries.package.jsonused during builds is updated withhomepage,license,desktopName, a richer description, and author email.Macroscope summarized 6f2eac5.