Refactor workspace reads to Effect FileSystem

[cursor]

What Changed

• Replaced the workspace read path's node:fs/promises and Effect.tryPromise calls with the injected Effect FileSystem service.
• Used scoped Effect file handles, File.stat, File.readAlloc, and Option for empty reads.
• Converted the focused test suite to @effect/vitest assertions, asserted normalized PlatformError data, and added preview-limit coverage.

Why

The read path bypassed an Effect service that was already injected and used by the write path. Keeping filesystem work inside Effect makes resource safety, structured failures, and layer-based testing consistent end-to-end.

Checklist

• This PR is small and focused
• I explained what changed and why
• No UI changes

Validation:

• pnpm exec vp test run src/workspace/WorkspaceFileSystem.test.ts (10 passed)
• pnpm exec vp check (0 errors; 9 pre-existing warnings)
• pnpm exec vp run typecheck (15 tasks passed)

  

Note

Refactor workspace readFile to use Effect FileSystem service APIs

• Replaces manual node:fs/promises calls (open/stat/read/close) with FileSystem.open, FileSystem.stat, and handle.readAlloc from the Effect platform, using Effect.scoped for automatic resource cleanup.
• Adds a new test case verifying that readFile returns at most the 1 MiB preview limit, sets byteLength to the full file size, and marks truncated: true.
• Behavioral Change: I/O failures are now wrapped as WorkspaceFileSystemOperationError with a PlatformError (including a reason tag such as NotFound) in the cause field, rather than raw Node.js errors.

📊 Macroscope summarized ea7294b. 1 file reviewed, 0 issues evaluated, 0 issues filtered, 0 comments posted

🗂️ Filtered Issues

No issues evaluated.

[macroscopeapp]

🟡 Medium workspace/WorkspaceFileSystem.ts:182

When the file handle close fails, readFile now throws an untyped defect instead of a WorkspaceFileSystemOperationError with operation close. The old code wrapped handle.close() failures in a typed error; Effect.scoped delegates cleanup to FileSystem.open's finalizer, which runs Effect.orDie(nodeClose(fd)), so a close failure terminates the effect as a defect rather than through the service's advertised error channel. Consider using Effect.acquireRelease (or Effect.acquireUseRelease) with an explicit close error mapping so close failures remain typed errors.

🚀 Reply "fix it for me" or copy this AI Prompt for your agent:

In file @apps/server/src/workspace/WorkspaceFileSystem.ts around line 182:

When the file handle close fails, `readFile` now throws an untyped defect instead of a `WorkspaceFileSystemOperationError` with operation `close`. The old code wrapped `handle.close()` failures in a typed error; `Effect.scoped` delegates cleanup to `FileSystem.open`'s finalizer, which runs `Effect.orDie(nodeClose(fd))`, so a close failure terminates the effect as a defect rather than through the service's advertised error channel. Consider using `Effect.acquireRelease` (or `Effect.acquireUseRelease`) with an explicit `close` error mapping so close failures remain typed errors.