Skip to content

Allow disabling built-in browser access#4049

Open
D3OXY wants to merge 1 commit into
pingdotgg:mainfrom
D3OXY:feat/disable-built-in-browser
Open

Allow disabling built-in browser access#4049
D3OXY wants to merge 1 commit into
pingdotgg:mainfrom
D3OXY:feat/disable-built-in-browser

Conversation

@D3OXY

@D3OXY D3OXY commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a server-backed Built-in browser setting, enabled by default
  • prevent agent sessions from receiving T3 browser MCP access when disabled
  • omit T3 browser developer instructions from Codex turns when disabled

Testing

  • vp check
  • vp run typecheck
  • vp test apps/server/src/provider/Layers/ProviderService.test.ts apps/server/src/provider/Layers/CodexSessionRuntime.test.ts packages/contracts/src/settings.test.ts

Settings UI screenshot

image

Note

Add toggle to disable the built-in browser in server settings

  • Adds enableBuiltInBrowser to the ServerSettings schema (default true) and exposes a toggle in the General settings panel.
  • When disabled, prepareMcpSession in ProviderService.ts revokes and clears any active MCP session instead of issuing credentials.
  • buildCodexDeveloperInstructions in CodexDeveloperInstructions.ts conditionally omits browser tool guidance based on the browserEnabled flag, which is derived from whether an MCP server is configured.
  • Behavioral Change: sessions started without a configured MCP server will no longer receive browser tool instructions in the developer prompt.

Macroscope summarized 711265f.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: cf45ad54-0264-46ce-8485-83806b5c46d0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Jul 16, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new user-facing feature to disable built-in browser access, affecting agent runtime behavior and modifying core provider infrastructure. The changes gate a significant capability and warrant human review.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant