Allow disabling built-in browser access#4049
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR introduces a new user-facing feature to disable built-in browser access, affecting agent runtime behavior and modifying core provider infrastructure. The changes gate a significant capability and warrant human review. You can customize Macroscope's approvability policy. Learn more. |
Summary
Testing
vp checkvp run typecheckvp test apps/server/src/provider/Layers/ProviderService.test.ts apps/server/src/provider/Layers/CodexSessionRuntime.test.ts packages/contracts/src/settings.test.tsSettings UI screenshot
Note
Add toggle to disable the built-in browser in server settings
enableBuiltInBrowserto theServerSettingsschema (defaulttrue) and exposes a toggle in the General settings panel.prepareMcpSessionin ProviderService.ts revokes and clears any active MCP session instead of issuing credentials.buildCodexDeveloperInstructionsin CodexDeveloperInstructions.ts conditionally omits browser tool guidance based on thebrowserEnabledflag, which is derived from whether an MCP server is configured.Macroscope summarized 711265f.