Handle auth timestamps and SSH ControlMaster handoff#2795
Handle auth timestamps and SSH ControlMaster handoff#2795ashvinnihalani wants to merge 1 commit into
Conversation
- Accept ISO string timestamps in auth contract schemas - Treat zero-exit SSH ControlMaster handoff as a live tunnel
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review Changes to auth contract schemas (packages/contracts/src/auth.ts) require human review per auth-sensitivity guidelines. Additionally, SSH tunnel probe logic changes alter runtime behavior by removing HTTP status code validation. You can customize Macroscope's approvability policy. Learn more. |
What Changed
Why
UI Changes
N/A
Checklist
Note
Handle SSH ControlMaster handoff and fix auth timestamp parsing
packages/contracts/src/auth.tschange allDateTimeUtctimestamp fields toDateTimeUtcFromStringso that string-encoded UTC datetimes are correctly parsed from API responses.packages/ssh/src/tunnel.tsnow accepts any HTTP response (not just 2xx) as a signal that the service is ready.Dateobjects directly will fail validation.Macroscope summarized d69eb1f.