Skip to content

Handle auth timestamps and SSH ControlMaster handoff#2795

Open
ashvinnihalani wants to merge 1 commit into
pingdotgg:mainfrom
ashvinnihalani:t3code/8d598b33
Open

Handle auth timestamps and SSH ControlMaster handoff#2795
ashvinnihalani wants to merge 1 commit into
pingdotgg:mainfrom
ashvinnihalani:t3code/8d598b33

Conversation

@ashvinnihalani
Copy link
Copy Markdown
Contributor

@ashvinnihalani ashvinnihalani commented May 24, 2026

What Changed

  • Accept ISO string timestamps in auth contract schemas
  • Treat zero-exit SSH ControlMaster handoff as a live tunnel

Why

  • ISO formatting parsing was just a type guard, not a parsing transformation
  • Control master is a performance optimization required for Corporate machines behind firewalls/proxy.

UI Changes

N/A

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • [N/A] I included before/after screenshots for any UI changes
  • [N/A] I included a video for animation/interaction changes

Note

Handle SSH ControlMaster handoff and fix auth timestamp parsing

  • Auth contract schemas in packages/contracts/src/auth.ts change all DateTimeUtc timestamp fields to DateTimeUtcFromString so that string-encoded UTC datetimes are correctly parsed from API responses.
  • SSH tunnel readiness check in packages/ssh/src/tunnel.ts now accepts any HTTP response (not just 2xx) as a signal that the service is ready.
  • An SSH process that exits with code 0 and no stderr is now treated as a ControlMaster handoff: the tunnel is kept alive rather than surfacing an error.
  • Behavioral Change: auth schemas now expect string input for datetime fields; any upstream code passing Date objects directly will fail validation.

Macroscope summarized d69eb1f.

- Accept ISO string timestamps in auth contract schemas
- Treat zero-exit SSH ControlMaster handoff as a live tunnel
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1894d68f-bbc1-432d-8318-42182324a825

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels May 24, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 24, 2026

Approvability

Verdict: Needs human review

Changes to auth contract schemas (packages/contracts/src/auth.ts) require human review per auth-sensitivity guidelines. Additionally, SSH tunnel probe logic changes alter runtime behavior by removing HTTP status code validation.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant