Skip to content

fix(codex): show web search query and url in tool call details#2093

Merged
juliusmarminge merged 9 commits into
pingdotgg:mainfrom
GuilhermeVieiraDev:feat/web-search-tool-call-details
Jul 20, 2026
Merged

fix(codex): show web search query and url in tool call details#2093
juliusmarminge merged 9 commits into
pingdotgg:mainfrom
GuilhermeVieiraDev:feat/web-search-tool-call-details

Conversation

@GuilhermeVieiraDev

@GuilhermeVieiraDev GuilhermeVieiraDev commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

What Changed

Codex webSearch tool calls now surface the actual query or opened URL in the work log detail instead of falling back to the generic Web search label with no useful context.

The adapter now checks item.query, then item.action.query, then item.action.url when building the detail string for web_search items.

Closes #1909.

Why

Right now Codex web search calls are not transparent enough. The work log just shows Web search, so there is no way to tell what the agent actually searched for or which URL it opened.

I kept the extra candidates isolated to web_search so this does not change detail precedence for other tool types that might also carry query or url fields.

UI Changes

Before:

image

After:

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Display-only adapter mapping scoped to web_search items; other item types keep the same detail precedence.

Overview
Codex web search work-log entries now show a meaningful detail string (search query, query list, pattern, or opened URL) instead of only the generic Web search title.

itemDetail in CodexAdapter.ts now takes itemType and, for web_search items only, prefers item.query, action.query, action.queries, action.pattern, and action.url before the existing command/title/summary fields. Item lifecycle and plan-completion mapping pass itemType through unchanged for other tool types.

Reviewed by Cursor Bugbot for commit b4f91a5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show web search query and URL in tool call details for Codex

Updates itemDetail in CodexAdapter.ts to extract query, queries, pattern, and url fields from web search items and their action objects. These fields are prepended as candidate detail sources when itemType === "web_search", so runtime events for started/updated/completed items now surface the search query or URL in the detail field. Non-web-search behavior is unchanged.

Macroscope summarized b4f91a5.

@coderabbitai

coderabbitai Bot commented Apr 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 00381ed4-0a94-42c6-9233-0a3b756f84c6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 16, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 16, 2026
@macroscopeapp

macroscopeapp Bot commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This change adds display-only information (query and URL) to web search tool call details. It's a self-contained UI enhancement with no impact on business logic or data processing.

You can customize Macroscope's approvability policy. Learn more.

@GuilhermeVieiraDev
GuilhermeVieiraDev force-pushed the feat/web-search-tool-call-details branch from 6a3ad63 to 07d670d Compare April 26, 2026 15:40
@macroscopeapp
macroscopeapp Bot dismissed their stale review April 26, 2026 15:41

Dismissing prior approval to re-evaluate 07d670d

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 26, 2026
@GuilhermeVieiraDev
GuilhermeVieiraDev force-pushed the feat/web-search-tool-call-details branch from 07d670d to 3342618 Compare April 26, 2026 15:58
@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Apr 26, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review April 26, 2026 16:00

Dismissing prior approval to re-evaluate 3342618

Comment thread apps/server/src/provider/Layers/CodexAdapter.ts Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 26, 2026
@macroscopeapp
macroscopeapp Bot dismissed their stale review April 26, 2026 16:07

Dismissing prior approval to re-evaluate d1c4943

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Apr 26, 2026
@juliusmarminge
juliusmarminge force-pushed the feat/web-search-tool-call-details branch from 43c680d to bc48c5e Compare June 16, 2026 17:31

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c08f90f. Configure here.

Comment thread apps/server/src/provider/Layers/CodexAdapter.ts
@macroscopeapp
macroscopeapp Bot dismissed their stale review July 19, 2026 16:33

Dismissing prior approval to re-evaluate b4f91a5

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Jul 19, 2026
@juliusmarminge
juliusmarminge merged commit 33f1cb4 into pingdotgg:main Jul 20, 2026
16 checks passed
adamfgr pushed a commit to agriffiths-bots/t3code that referenced this pull request Jul 21, 2026
* fix(server): resolve Claude SDK executable path on Windows npm installs (pingdotgg#3740)

* Fix project action preview settings persistence (pingdotgg#3842)

* fix(desktop): allow clipboard writes in the preview browser (pingdotgg#3889)

* fix(web): handle sidebar shortcut before editors (pingdotgg#3921)

* fix(server): recognize Bedrock-backed Claude as authenticated (pingdotgg#3931)

* Fix incorrect pluralization of “entry” (pingdotgg#3933)

* feat(server): title background-task work-log rows with the task name (pingdotgg#3751)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* fix: delegate OpenCode session titles to provider (pingdotgg#3720)

* Archive selected threads from the context menu (pingdotgg#3895)

* fix(cli): support force removing projects (pingdotgg#3922)

* fix: allow sidebar to be shrunk when wider than viewport (pingdotgg#2456)

Co-authored-by: Shoaib Ansari <shoaibansari@Shoaibs-Mac-mini.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* fix(codex): show web search query and url in tool call details (pingdotgg#2093)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Add Codex launch arguments setting (pingdotgg#2892)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: root <root@localhost.localdomain>

* [orchestration] Clear stale active turn when session becomes inactive (pingdotgg#3159)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Regenerate Codex reset credit protocol bindings (pingdotgg#4173)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(preview): preserve direct localhost navigation (pingdotgg#3939)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* Synchronize mobile threads with authoritative shell snapshots (pingdotgg#4163)

Co-authored-by: codex <codex@users.noreply.github.com>

* Gate iOS glass layout on native support (pingdotgg#4032)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(opencode): resume the OpenCode session on follow-ups instead of starting an empty one (pingdotgg#3617)

Co-authored-by: codex <codex@users.noreply.github.com>

* fix(server): use CLI for OpenCode health check instead of spawning server (pingdotgg#4153)

* fix(web): scope timeline minimap hover target to the side gutter (pingdotgg#3869)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* [codex] show complete approval details (pingdotgg#4111)

* fix(web): paint text selection over composer chips (pingdotgg#4139)

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

* [codex] preserve custom model slugs (pingdotgg#4168)

* fix(web): preview workspace images in the file panel (pingdotgg#3996)

Co-authored-by: Rhiz3K <rhiz3k@protonmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* feat(web): drag files from the explorer into the chat composer (pingdotgg#4140)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>

* fix(desktop): preserve main window bounds (pingdotgg#3851)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>

* perf(orchestration): speed up new-chat propagation and offline catch-up (pingdotgg#4177)

Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>

* Finale: upgrade changed files card to fix various UI issues (pingdotgg#4113)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

* fix(web): always show environment chip for remote projects (pingdotgg#4217)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* chore: reconcile upstream sync (20260721) — typecheck/test fixups

Post-cherry-pick reconciliation of the shell/thread sync rewrite:
- adopt upstream's client shell.ts + shell-sync.test.ts (drops the fork's
  superseded #142 replay-gap watchdog; server no longer emits 'caught-up')
- remove the orphaned 'caught-up' contract member and obsolete fork shell
  server tests (upstream's coalescing tests cover the behavior)
- keep the fork's thread reconciliation, resubscribing via subscribeDynamic
  (establish base once; foreground/session resubscribe via the live cursor)
- add latestSequence to OrchestrationEngine test mocks; thread dispatch
  authority in bin.test; narrow stream-item unions past the new 'synchronized'

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: David Whatley <nsxdavid@gmail.com>
Co-authored-by: coach007 <6238600+keeperxy@users.noreply.github.com>
Co-authored-by: Carlos Rico-Ospina <carlosricojr@gmail.com>
Co-authored-by: Andrew Barnes <bortstheboat@gmail.com>
Co-authored-by: Pieter van Zyl <20579513+PieterVanZyl-Dev@users.noreply.github.com>
Co-authored-by: mel <mcmelon@nodiumhosting.com>
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Tristan Knight <tris203@gmail.com>
Co-authored-by: Christoph Herzog <a.github@omega-id.com>
Co-authored-by: Shoaib <shoaib050326@gmail.com>
Co-authored-by: Shoaib Ansari <shoaibansari@Shoaibs-Mac-mini.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Guilherme Vieira <46866023+GuilhermeVieiraDev@users.noreply.github.com>
Co-authored-by: James <105842516+jamesx0416@users.noreply.github.com>
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
Co-authored-by: root <root@localhost.localdomain>
Co-authored-by: Andrew Forster <76947376+Andrew-Forster@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Chris Michael Guzman <67719167+Chrrxs@users.noreply.github.com>
Co-authored-by: Vadym Kotai <vdmkotai@gmail.com>
Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com>
Co-authored-by: xxashxx-svg <xxanshxx9@gmail.com>
Co-authored-by: Maxwell Young <maxtheyoung@gmail.com>
Co-authored-by: Yordis Prieto <yordis.prieto@gmail.com>
Co-authored-by: Rhiz3K <33246262+Rhiz3K@users.noreply.github.com>
Co-authored-by: Rhiz3K <rhiz3k@protonmail.com>
Co-authored-by: Anirudh Coontoor <me@anirudhs.net>
Co-authored-by: Rusiru Sadathana <rusirusadathana@gmail.com>
Co-authored-by: ss <69873514+sandersonstabo@users.noreply.github.com>
Co-authored-by: wizzoapp[bot] <254688279+wizzoapp[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: show what web search did in the tool call

2 participants