fix(web): auto-scroll composer autocomplete list on keyboard navigation#1344
Open
kerdofficial wants to merge 1 commit intopingdotgg:mainfrom
Open
fix(web): auto-scroll composer autocomplete list on keyboard navigation#1344kerdofficial wants to merge 1 commit intopingdotgg:mainfrom
kerdofficial wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added
scrollIntoView({ block: "nearest" })to the active item in the composer@-mention autocomplete dropdown when navigating with arrow keys.Single file changed:
ComposerCommandMenu.tsx(+9 lines).Why
When the autocomplete list has more items than fit in the visible area (
max-h-64), pressing ArrowDown/ArrowUp updates the highlighted item but does not scroll the list. The selected item moves off-screen while the viewport stays fixed, making keyboard navigation unusable for items below the fold.The keyboard navigation is handled manually via
nudgeComposerMenuHighlightinChatView.tsx(not through base-ui's built-in keyboard handling), so base-ui's auto-scroll never fires. This fix adds an explicitscrollIntoViewcall on the active item.UI Changes
Before
before.mp4
After
after.mp4
Checklist
Note
Auto-scroll active item in composer autocomplete list on keyboard navigation
When navigating the composer command menu with the keyboard, the active item now calls
scrollIntoViewto stay visible within the scrollable container. This is implemented inComposerCommandMenuItemvia auseEffectthat triggers wheneverisActivebecomes true.Macroscope summarized 2db97dd.