Skip to content

fix(server): block updates under legacy service launchers #11940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juliusmarminge merged 1 commit into from
Sep 15, 2026
+13 −5
Merged

fix(server): block updates under legacy service launchers #11940

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/server/src/cloud/servicePreflight.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,22 @@ import { expect, it } from "@effect/vitest";
import { runServicePreflight } from "./servicePreflight.ts";
import { SERVICE_LAUNCHER_PROTOCOL } from "./serviceProtocol.ts";

it("requires the database-snapshot launcher protocol", () => {
it.each([1, 2])("blocks legacy launcher protocol %i", (launcherProtocol) => {
expect(
runServicePreflight({
databasePath: "/missing/state.sqlite",
launcherProtocol: SERVICE_LAUNCHER_PROTOCOL - 1,
launcherProtocol,
version: "1.2.3",
}),
).toMatchObject({ status: "blocked", version: "1.2.3" });
).toEqual({
status: "blocked",
version: "1.2.3",
reason:
"This release requires a newer T3 Code service launcher. Update it on the server machine.",
});
});

it("accepts the current launcher protocol", () => {
expect(
runServicePreflight({
databasePath: "/missing/state.sqlite",
Expand Down
5 changes: 3 additions & 2 deletions apps/server/src/cloud/serviceProtocol.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import type { ServerSelfUpdateOutcome } from "@t3tools/contracts";

/** Protocol 2 snapshots SQLite before trials so migrations can be rolled back safely. */
export const SERVICE_LAUNCHER_PROTOCOL = 2 as const;
// Protocol 3 requires the standalone executable layout. Bump when runtimePaths
// or the installed runtime tree changes incompatibly; launchers survive self-updates.
export const SERVICE_LAUNCHER_PROTOCOL = 3 as const;
export const SERVICE_LAUNCHER_CONTEXT_ENV = "T3_SERVICE_LAUNCHER_CONTEXT";
export const SERVICE_STATE_FILE = "service-state.json";
/** Written by the launcher just before an explicit stop kills its child, so
Expand Down
Loading