Conversation
Author
|
Could a maintainer please add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10860.
What Changed
Collapsed Android composer now forces single line with ellipsis, and uses minHeight 40 instead of fixed height 36. Expanded state restores multiline.
Files: apps/mobile/src/features/threads/ThreadComposer.tsx, apps/mobile/modules/t3-composer-editor/android/src/main/java/expo/modules/t3composereditor/T3ComposerEditorView.kt
Why
The placeholder Ask the repo agent, or run a command wrapped to two lines inside a single line pill, so the second line clipped below the border. Narrow rows with the plus and stop buttons made it worse. Scaled fonts made it worse.
UI Changes
Before shot attached from the Play Store build. After shot to follow from a patched build.
Verification
CI is the gate. No local Android build run here. Needs a native preview binary to confirm on device.
Checklist