Conversation
Signed-off-by: Wish <breezewish@outlook.com> (cherry picked from commit 44ad2b3)
Signed-off-by: Wish <breezewish@outlook.com> (cherry picked from commit 81b8ae1)
* Add tici.proto and update proto.lock files * Update proto.lock * Fix tici proto build process with directory structure and compatibility fixes * Fix relative import in tici.pb.go * Update go.mod and go.sum for dependencies * fix the go complie (cherry picked from commit 7e66865)
…ngcap#364) (cherry picked from commit bb7af0d)
Signed-off-by: Wish <breezewish@outlook.com> (cherry picked from commit c8b1400)
(cherry picked from commit 4768c71)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe protobuf contracts add TiFlash full-text-search support and define a TiCI indexer gRPC API. The Go generation script places TiCI output in the main ChangesTiFlash full-text search
TiCI indexer API
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Merge Risk: ⚪ Minimal · up to No concrete merge-blocking behavior issue is established in the added protobuf contracts or generation wiring. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 Buf (1.72.0)proto/executor.protofatal: unable to access 'https://github.com/pingcap/tipb.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server proto/expression.protofatal: unable to access 'https://github.com/pingcap/tipb.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server proto/tici/indexer.protofatal: unable to access 'https://github.com/pingcap/tipb.git/': Failed to connect to github.com:443 over proxy 127.0.0.1 after 0 ms: Could not connect to server Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the schemas bright Comment |
Summary
Backport the existing FTS/TiCI protocol stack to
feature/release-8.5-ftsfor pingcap/tidb#71280.Cherry-pick the eight previously adapted commits from
cp-fts-858-tipb(84229a99a9e2): #357, #360, #362, #364, #366, #374, #389 and #386. Preserve query/tokenizer metadata, TiCI messages, FTS scalar functions and Boolean expressions, phrase matching, and TopN parameters with their existing field numbers and generated Go bindings.The target starts at
5817d66db9c3; the resulting tree exactly matches the old audited FTS branch. Each commit retains its cherry-pick provenance.Validation
go test -mod=readonly ./...passed.git diff --checkpassed.Summary by CodeRabbit