disagg: adapt GC merge fan-in after S3 read failures (#10800)#10804
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
|
@kolafish: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang, JinheLin, kolafish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bcab024
into
pingcap:release-nextgen-20251011
This is an automated cherry-pick of #10800
What problem does this PR solve?
Issue Number: close #10798, ref #10794
Problem Summary:
Background GC merges can still fan in too many segments after bounded S3 stream retries are exhausted. That keeps a single GC merge exposed to long remote-read windows, while medium forward seeks still prefer draining the existing stream instead of reopening from the target offset.
What is changed and how it works?
S3RandomAccessFile::readandS3RandomAccessFile::seekthrowErrorCodes::S3_ERRORafter the bounded stream retry budget is exhausted, with doc comments for the public APIs and concise comments around the retry-exhaustion branchgc_mergeable_segments_capso background GC merge fan-in is capped and can be reduced afterS3_ERRORgcTrySegmentMergefails withS3_ERROR, and recover the cap only aftercheckSegmentUpdatesucceedsCheck List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit
New Features
Chores