functions-and-operators: fix JSON_DEPTH() example path to match its own JSON document - #23865
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesJSON depth documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Merge Risk: ⚪ Minimal · up to The documentation correction aligns the example path with the JSON document and is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
The
JSON_DEPTH()example infunctions-and-operators/json-functions/json-functions-return.mdlists three path levels —
`$`,`$.weather`, and (labeled "weathercurrent")
`$.weather.sunny`. But the actual JSON document used in theexample right below is
{"weather": {"current": "sunny"}}, where"sunny"is the value, not a key — the real third-level path is
`$.weather.current`.Fixes the path in the bullet list to match the document the example
actually queries. (Found while translating this file into Japanese; the
Japanese-side inconsistency this caused is fixed separately.)
Verified against a live TiDB instance (
tiup playground, TiDB v8.5.x):$.weather.currentcorrectly resolves to"sunny";$.weather.sunnydoesnot exist in the document and returns
NULL, confirming the path in thebullet list was wrong.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code