Conversation
The metric type column in the Datadog, New Relic, and Prometheus/Grafana integration docs had been translated to katakana (gauge -> ゲージ, count -> カウント, histogram -> ヒストグラム). These are literal metric type values from the monitoring systems' own APIs, matching the English source and the untranslated sibling doc (monitor-datadog-integration-for-tidb-x.md), so they should stay in English. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates four TiDB Cloud monitoring documentation files. Metric types and selected table labels now use English terms. Metric names, labels, descriptions, and table structures remain unchanged except for two related description parentheticals. ChangesMetric terminology alignment
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR aligns metric terminology in the Japanese monitoring documentation and presents no concrete merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The previous commit's blanket replacement incorrectly turned the prose description "ステートメントの期間ヒストグラム" (a natural Japanese statistics term) into "ステートメントの期間histogram". Only the Type column's literal metric-type value should stay in English; restore the katakana term in the prose description. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Unknown/Normal/Warning/Failed/Stopped/Finished/Other labels describe literal numeric values (-1/0/1/2/3/4/6/7) that the changefeed_status gauge metric returns, matching the value-display labels used by TiDB Cloud's own monitoring dashboards. Like the metric type values fixed earlier in this PR, these are literal values rather than prose to translate, so keep them in English, matching the English source. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ja-metric-type-english-terms-local # Conflicts: # tidb-cloud/monitor-datadog-integration.md # tidb-cloud/monitor-new-relic-integration.md
What is changed, added or deleted? (Required)
In the Japanese translations of the Datadog, New Relic, and Prometheus/Grafana
integration docs, the "metric type" column had translated the literal metric
type values into katakana:
gauge->ゲージcount->カウントhistogram->ヒストグラムThese are literal enum values from each monitoring system's own API/metadata
(matching the English source verbatim), not prose to translate, so this PR
reverts them to English. This also makes
monitor-datadog-integration.mdconsistent with its sibling
monitor-datadog-integration-for-tidb-x.md,which already kept these values in English.
Additionally, the
changefeed_statusmetric's value-description column(
Unknown/Normal/Warning/Failed/Stopped/Finished/Other, describingwhat each numeric value -1/0/1/2/3/4/6/7 means) had likewise been translated
to Japanese in all 4 files. These are literal value-display labels matching
TiDB Cloud's own monitoring dashboards, not prose, so they are reverted to
English as well.
Files changed:
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code