i18n(ja): restore admonition labels to English (Note/Warning/Tip)#23292
i18n(ja): restore admonition labels to English (Note/Warning/Tip)#23292yahonda wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
ti-chi-bot
Bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the admonition headers across various Japanese documentation files by replacing localized headers (such as "注記：", "ヒント：", and "警告：") with their English equivalents ("Note:", "Tip:", and "Warning:") to ensure proper rendering and localization by the documentation platform. The review feedback points out a formatting issue in "backup-and-restore-using-dumpling-lightning.md" where a note was styled as inline bold text instead of a blockquote admonition, which would prevent correct rendering, and provides a suggestion to fix it.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
ti-chi-bot
Bot
removed
the
do-not-merge/work-in-progress
[LGTM Timeline notifier]Timeline:
|
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@yahonda Would you please resolve conflicts in this PR? Thanks. |
qiancai
added
translation/no-need
The documentation website automatically renders the English admonition markers (`> **Note:**`, `> **Warning:**`, `> **Tip:**`) into localized labels, so the Japanese source does not need to translate them. Restore the translated labels back to English and let the site handle localization: - **注記：** -> **Note:** - **警告：** -> **Warning:** - **ヒント：** -> **Tip:** Label text only; no other content changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
f604ce5 to
80c870b
Compare
|
Conflicts have been addressed. |
2 participants
What is changed, added or deleted? (Required)
The documentation website automatically renders the English admonition markers (
> **Note:**,> **Warning:**,> **Tip:**) into localized labels, so the Japanese source does not need to translate them. This PR restores the translated admonition labels back to English and lets the site handle localization:**注記：**→**Note:**(1808)**警告：**→**Warning:**(245)**ヒント：**→**Tip:**(277)2330 labels across 781 files. Label text only — no other content changed (verified: every changed line is one of the three label substitutions, and 0 Japanese admonition labels remain).
In addition, one inline (non-blockquote) note in
backup-and-restore-using-dumpling-lightning.mdis aligned with the English source style (**Note**:, colon outside the bold).Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?