Skip to content

i18n(ja): miscellaneous review fixes (bit-shift description)#23274

Draft
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-misc-review-fixes
Draft

i18n(ja): miscellaneous review fixes (bit-shift description)#23274
yahonda wants to merge 5 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-ja-misc-review-fixes

Conversation

@yahonda

@yahonda yahonda commented Jul 15, 2026

Copy link
Copy Markdown
Member

Miscellaneous Japanese fluency fixes found during review, kept separate from the release-notes PR (#23254).

  • functions-and-operators/bit-functions-and-operators.md: fix the left-shift example — n`位置左に左にn (EN: "shift ... to the left by n positions"), and add the missing after 1<<n.

Further small review findings may be added to this PR.

  • Might cause conflicts after applied to another branch

@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kissmydb for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Japanese documentation for bitwise functions to clarify the description of the left-shift operator. The reviewer suggested a minor improvement to use 'ビット' (bits) instead of '桁' (digits) for better technical accuracy and consistency with the rest of the document.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

`<<`演算子は左シフト演算を実行し、数値のビットを指定された位置数だけ左にシフトし、右側の空いたビットをゼロで埋めます。

たとえば、次のステートメントでは、 `1<<n`使用して、バイナリ値`1` `n`位置左にシフトします
たとえば、次のステートメントでは、 `1<<n`を使用して、バイナリ値`1`を左に`n`桁シフトします

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For bit-shift operations, it is technically more accurate to use 'ビット' (bits) instead of '桁' (digits/positions). This also ensures consistency with other terms used in the document (such as 'ビットをゼロで埋めます').

We recommend updating it as follows:

たとえば、次のステートメントでは、 `1<<n`を使用して、バイナリ値`1`を左に`n`ビットシフトします。
References
  1. Technical accuracy and terminology consistency: Using 'ビット' (bits) instead of '桁' (digits) is technically more accurate for bitwise operations and consistent with the rest of the document. (link)

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/develop This PR relates to the area of TiDB App development. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 15, 2026
@yahonda
yahonda force-pushed the fix-ja-misc-review-fixes branch from 8e3296d to 44d59a1 Compare July 16, 2026 00:38
@qiancai qiancai added translation/no-need No need to translate this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2026
yahonda and others added 5 commits July 16, 2026 18:06
…issing を)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nce end in release-4.0-ga

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…time, release-4.0.15)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…uning-best-practice (gemini review)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…, spaces, storage, IAM typo)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@yahonda
yahonda force-pushed the fix-ja-misc-review-fixes branch from 44d59a1 to 3ad44d0 Compare July 16, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants