Update built-in-monitoring-premium.md#22987
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request introduces an unnecessary blank line before the "Database" heading in the built-in monitoring documentation. The reviewer correctly pointed out that only a single blank line is required before headings according to the style guide, and requested the removal of the duplicate blank line.
| | Connection Count | All, active connection | All: the number of connections. <br/> Active connections: the number of active connections. | | ||
| | Disconnection Count | {result} | The number of clients disconnected. | | ||
|
|
||
|
|
There was a problem hiding this comment.
Only a single blank line is required before headings. Please remove the duplicate blank line.
References
- Add a blank line before and after headings and lists. (link)
Suggestion: add two TTL monitoring metrics to the Overview tableTwo new TTL metrics are being introduced to the Metrics page (Instance Overview tab) for Premium clusters. I'd like to suggest adding them as two new rows at the end of the Overview table (after Proposed addition: | Table Count by TTL Schedule Delay | `{name}` | Shows how many TTL-enabled tables fall into each schedule delay range. The `name` label is a delay bucket. Possible bucket values: `01 hour`, `02 hour`, `06 hour`, `12 hour`, `24 hour`, `72 hour`, `one week`, `others`. |
| TTL Insert/Delete Rows by Day | `insert current day`, `delete current day`, `insert last day`, `delete last day`, `insert 2 days ago`, `delete 2 days ago` | Shows the total number of rows written into TTL-tracked tables (insert) and rows deleted by TTL jobs (delete) within a calendar day. A persistent insert/delete imbalance — where inserts consistently exceed deletes — indicates TTL is not keeping pace with data ingestion, leading to storage growth. Day-over-day comparison helps distinguish normal traffic variation from a degradation trend. |/cc @yoanahuo |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?