Skip to content

Update built-in-monitoring-premium.md#22987

Open
huoyao1125 wants to merge 2 commits into
pingcap:release-8.5from
huoyao1125:patch-41
Open

Update built-in-monitoring-premium.md#22987
huoyao1125 wants to merge 2 commits into
pingcap:release-8.5from
huoyao1125:patch-41

Conversation

@huoyao1125
Copy link
Copy Markdown

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot Bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jun 1, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jun 1, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oreoxmt for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an unnecessary blank line before the "Database" heading in the built-in monitoring documentation. The reviewer correctly pointed out that only a single blank line is required before headings according to the style guide, and requested the removal of the duplicate blank line.

| Connection Count | All, active connection | All: the number of connections. <br/> Active connections: the number of active connections. |
| Disconnection Count | {result} | The number of clients disconnected. |


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Only a single blank line is required before headings. Please remove the duplicate blank line.

References
  1. Add a blank line before and after headings and lists. (link)

@huoyao1125
Copy link
Copy Markdown
Author

huoyao1125 commented Jun 1, 2026

Suggestion: add two TTL monitoring metrics to the Overview table

Two new TTL metrics are being introduced to the Metrics page (Instance Overview tab) for Premium clusters. I'd like to suggest adding them as two new rows at the end of the Overview table (after Disconnection Count).

Proposed addition:

| Table Count by TTL Schedule Delay | `{name}` | Shows how many TTL-enabled tables fall into each schedule delay range. The `name` label is a delay bucket. Possible bucket values: `01 hour`, `02 hour`, `06 hour`, `12 hour`, `24 hour`, `72 hour`, `one week`, `others`. |
| TTL Insert/Delete Rows by Day | `insert current day`, `delete current day`, `insert last day`, `delete last day`, `insert 2 days ago`, `delete 2 days ago` | Shows the total number of rows written into TTL-tracked tables (insert) and rows deleted by TTL jobs (delete) within a calendar day. A persistent insert/delete imbalance — where inserts consistently exceed deletes — indicates TTL is not keeping pace with data ingestion, leading to storage growth. Day-over-day comparison helps distinguish normal traffic variation from a degradation trend. |

/cc @yoanahuo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant