Fix stale versioned docs links#22875
Conversation
ti-chi-bot
Bot
added
contribution
|
Welcome @tdashelby-cmyk! |
|
Hi @tdashelby-cmyk. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
ti-chi-bot
Bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates numerous documentation links to point to the archived documentation site (docs-archive.pingcap.com), ensures consistent trailing slashes, and corrects several link anchors across various files. Feedback includes a suggestion to remove a roadmap section that is no longer informative after its link was removed and a correction for a specific link anchor to maintain consistency with documentation standards.
| ## TiDB kernel | ||
|
|
||
| For the roadmap of TiDB kernel, refer to [TiDB Roadmap](https://docs.pingcap.com/tidb/dev/tidb-roadmap). | ||
| For the roadmap of TiDB kernel, refer to TiDB Roadmap. |
There was a problem hiding this comment.
Since the link to the TiDB kernel roadmap has been removed, this section is no longer informative. To avoid confusion, I suggest removing this 'TiDB kernel' section entirely.
| Starting from v7.2.0, TiFlash supports a new execution model, the pipeline execution model. | ||
|
|
||
| - For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs.pingcap.com/tidb/v7.2/system-variables#tidb_enable_tiflash_pipeline_model-introduced-since-v720). | ||
| - For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-introduced-since-v720). |
There was a problem hiding this comment.
The anchor in this link appears to be incorrect. For consistency with other similar links in the documentation, it should be ...-new-in-v720 instead of ...-introduced-since-v720.
| - For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-introduced-since-v720). | |
| - For v7.2.0 and v7.3.0: The pipeline execution model is experimental and is controlled by [`tidb_enable_tiflash_pipeline_model`](https://docs-archive.pingcap.com/tidb/v7.2/system-variables/#tidb_enable_tiflash_pipeline_model-new-in-v720). |
|
/ok-to-test |
ti-chi-bot
Bot
added
ok-to-test
|
@qiancai: Your lgtm message is repeated, so it is ignored. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
qiancai
added
needs-cherry-pick-release-8.5
Synced from: pingcap/docs#22875 Target PR: pingcap#21630 AI Provider: azure Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ti-chi-bot
Bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
4 participants
What changed
This PR updates stale documentation links reported in #22867:
docs-archive.pingcap.com, preserving the original versioned targets.secure-connections-to-serverless-clusterspage.Verification
rg -n https://docs\\.pingcap\\.com/tidb/v(7\\.2|7\\.6|8\\.3)/|https://docs\\.pingcap\\.com/tidbcloud/secure-connections-to-starter-clusters/|https://docs\\.pingcap\\.com/tidb/dev/tidb-roadmap -g *.mdreturns no matches.Invoke-WebRequest; all returned HTTP 200.git diff --checknpx --yes markdownlint-cli@0.17.0 <changed files>