Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,14 @@ supported as exact pairs; on the 0.x line they are independent. See the

## Unreleased (next release)

- `timeframe.in_seconds` and `timeframe.change` resolve an evaluated empty
string to the chart period, including input, variable, function-return and
named arguments. The argument is evaluated once, and nonempty strings keep
their explicit period. Dotted builtin signatures retain supplied arguments,
including escaped string literals and VWAP anchors. (#394)
- Script identifiers spelled like integer-to-float conversion temporaries,
including the underscore suffixes of nested conversions, now use the
generator's reserved-name escaping.
- A zone name the engine rejects now makes calendar-form `timestamp()` stop the
run at its first evaluation, instead of silently calculating a UTC value.
The paired engine reports a typed timezone error identifying the failed bar.
Expand Down
7 changes: 5 additions & 2 deletions pineforge_codegen/codegen/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ def cpp_code_only(cpp: str) -> str:
_pf_series_raw _pf_raw _pf_val_t _pf_out _pf_prior
_pf_hist_offset_raw _pf_hist_offset_numeric _pf_hist_offset _pf_hist_bar
_pf_calendar_ts _pf_calendar_tz
_pf_timeframe_arg
_tz _yr _mo _dy _hr _min _sc _res _old _old_tz _had_old _secs
_last_tz _last_yr _last_mo _last_dy _last_hr _last_min _last_sc
_last_res
Expand All @@ -542,15 +543,16 @@ def cpp_code_only(cpp: str) -> str:
_pf_number_text
_pf_substring_text _pf_substring_begin _pf_substring_end _pf_substring_error
_pf_array_new_size _pf_array_new_value _pf_array_new_size_type _pf_array_new_error
_pf_read _pf_v5_l _pf_v5_r _pf_wide_l _pf_wide_r
_pf_read _pf_v5_l _pf_v5_r _pf_wide_l _pf_wide_r _pf_w
_pf_symbol _pf_colon _pf_color _pf_bar_back _pf_ema_seeding
_pf_history_array _pf_history_offset _pf_matrix_target
_pf_array_index_type
_pf_sort_descending _pf_sort_element _pf_sort_indices _pf_sort_i _pf_sort_j
_pf_sort_left _pf_sort_right _pf_sort_left_na _pf_sort_right_na
""".split())
# These numbered members and locals keep their source-order spelling rather
# than allocating against authored names. Reserve their complete spellings,
# than allocating against authored names. Double coercions append underscores
# to _pf_w to distinguish nested temporaries. Reserve their complete spellings,
# just as for fixed temporaries, without reserving ordinary underscore names.
_CPP_TEMPORARY_PATTERN = re.compile(
r"_v\d+|_secval_\d+(?:_v\d+)?|_tuple_result_\d+(?:_elem_\d+)?|_tuple_unused_\d+|__switch_val_\d+"
Expand All @@ -560,6 +562,7 @@ def cpp_code_only(cpp: str) -> str:
r"|_pf_every_bar_ta_\d+|_pf_shared_\d+_\d+|__pf_array\w*|__pf_raw_\w+"
r"|_pf_collection_hist_\w+"
r"|_pf_substring_arg\d+"
r"|_pf_w_+"
r"|_req_sec_(?:lower_tf_)?\d+(?:_\d+)?|_precalc_\w+|_sec\d+_\w+"
r"|_pf_(?:sec|rec)_missing_\d+|_eval_security_\d+"
r"|_RuntimeSec\d+|_runtime_(?:feed|request)_\d+"
Expand Down
65 changes: 45 additions & 20 deletions pineforge_codegen/codegen/visit_call.py
Original file line number Diff line number Diff line change
Expand Up @@ -3211,22 +3211,45 @@ def _visit_func_call(self, node: FuncCall) -> str:
return f'{log_funcs[func_name]}({self._visit_expr(message)})'
return '"" /* unsupported log */'

# timeframe.* calls (e.g., timeframe.change) — not supported in single-TF backtest
# An empty timeframe argument denotes the chart period, whether it
# comes from a literal, an input or a user call. Bind by parameter
# name and resolve the evaluated string, not the argument's AST form.
if namespace == "timeframe":
if func_name == "change":
tf_arg = self._visit_expr(node.args[0]) if node.args else 'script_tf_'
# Symbol-clock overload: D/W/M boundaries fall on the SYMBOL's
# session day (17:00 ET on OANDA forex, 09:30 ET RTH on
# equities), intraday buckets on the session-open grid — the
# same clock request.security aggregation uses. UTC/24x7
# syminfo reduces to the tz-less epoch math bit-for-bit.
if func_name in ("change", "in_seconds"):
argument = self._resolve_func_args(
node, f"timeframe.{func_name}",
).get("timeframe")

def timeframe_call(tf_arg: str) -> str:
if func_name == "change":
# Keep the symbol-clock overload for calendar and
# session-anchored intraday boundaries.
return (
f'tf_change(prev_bar_timestamp_, current_bar_.timestamp, {tf_arg}, '
'syminfo_.timezone, syminfo_.session)'
)
return f'tf_to_seconds({tf_arg})'

if argument is None:
return timeframe_call("script_tf_")
argument_cpp = self._visit_expr(argument)
if cpp_is_plain_read(argument_cpp):
# Keep resolved locals and parameters as direct engine
# arguments when nonempty. Stable reads can be checked
# without introducing another binding.
return (
f'(({argument_cpp}).empty() ? {timeframe_call("script_tf_")} : '
f'{timeframe_call(argument_cpp)})'
)
# A function-return argument can carry state. Evaluate it
# once before testing emptiness and passing the chosen value.
call = timeframe_call(
"(_pf_timeframe_arg.empty() ? script_tf_ : _pf_timeframe_arg)"
)
return (
f'tf_change(prev_bar_timestamp_, current_bar_.timestamp, {tf_arg}, '
'syminfo_.timezone, syminfo_.session)'
'([&]() { const std::string _pf_timeframe_arg = '
f'({argument_cpp}); return {call}; }}())'
)
if func_name == "in_seconds":
tf_arg = self._visit_expr(node.args[0]) if node.args else 'script_tf_'
return f'tf_to_seconds({tf_arg})'
# Defensive: support_checker.NOT_YET_FUNC should already have rejected
# any unhandled timeframe.* call. Reaching here implies the checker was
# bypassed.
Expand Down Expand Up @@ -4405,18 +4428,20 @@ def _resolve_func_args(self, node: FuncCall, sig_key: str) -> dict:

Uses the PineScript parameter ordering from signatures registry.
"""
# sig_key is like "strategy.entry" -> namespace="strategy", func_name="entry"
# Namespace records use their short name; dotted builtin records use
# the complete key in BUILTIN_FUNCTIONS (e.g. timeframe.change).
parts = sig_key.split(".", 1)
intrinsic = (
sigs.get_intrinsic(parts[0], parts[1]) if len(parts) == 2 else None
)
if intrinsic is None:
intrinsic = sigs.get_intrinsic(None, sig_key)
validate_intrinsic_keywords(
sigs.get_intrinsic(parts[0], parts[1]) if len(parts) == 2
else sigs.get_intrinsic(None, sig_key),
intrinsic,
node.kwargs,
pine_version=self.ctx.ast.version,
)
if len(parts) == 2:
param_names = sigs.get_param_names(parts[0], parts[1]) or []
else:
param_names = sigs.get_param_names(None, sig_key) or []
param_names = intrinsic.param_names if intrinsic is not None else []
result: dict = {}
# Map positional args by parameter name
for i, arg in enumerate(node.args):
Expand Down
186 changes: 186 additions & 0 deletions tests/fixtures/empty_timeframe/arguments.pine
Original file line number Diff line number Diff line change
@@ -0,0 +1,186 @@
//@version=6
strategy("Empty timeframe arguments", currency = currency.NONE)
frameInput = input.timeframe("", "Frame input")
frameString = input.string("", "String input")
frameVariable = frameString
_pf_timeframe_arg = frameString
pf_safe__pf_timeframe_arg = "240"
plainVariable = ""
var string persistentFrame = ""
emptyFrame() => ""
returnedFrame(string frameArg) => frameArg
secondsPos(string frameArg) => timeframe.in_seconds(frameArg)
secondsNamed(string frameArg) => timeframe.in_seconds(timeframe = frameArg)
changePos(string frameArg) => timeframe.change(frameArg)
changeNamed(string frameArg) => timeframe.change(timeframe = frameArg)
secondsCapturedPos(string _pf_timeframe_arg) => timeframe.in_seconds(_pf_timeframe_arg)
secondsCapturedNamed(string _pf_timeframe_arg) => timeframe.in_seconds(timeframe = _pf_timeframe_arg)
changeCapturedPos(string _pf_timeframe_arg) => timeframe.change(_pf_timeframe_arg)
changeCapturedNamed(string _pf_timeframe_arg) => timeframe.change(timeframe = _pf_timeframe_arg)
secondsStatefulPos(string frameArg) =>
var string savedFrame = frameArg
timeframe.in_seconds(savedFrame)
secondsStatefulNamed(string frameArg) =>
var string savedFrame = frameArg
timeframe.in_seconds(timeframe = savedFrame)
changeStatefulPos(string frameArg) =>
var string savedFrame = frameArg
timeframe.change(savedFrame)
changeStatefulNamed(string frameArg) =>
var string savedFrame = frameArg
timeframe.change(timeframe = savedFrame)
countedFrame(array<int> counter, string frameArg) =>
array.set(counter, 0, array.get(counter, 0) + 1)
frameArg
S_literal_pos = timeframe.in_seconds("")
S_literal_named = timeframe.in_seconds(timeframe = "")
S_input_pos = timeframe.in_seconds(frameInput)
S_input_named = timeframe.in_seconds(timeframe = frameInput)
S_string_input_pos = timeframe.in_seconds(frameString)
S_string_input_named = timeframe.in_seconds(timeframe = frameString)
S_variable_pos = timeframe.in_seconds(frameVariable)
S_variable_named = timeframe.in_seconds(timeframe = frameVariable)
S_temporary_name_pos = timeframe.in_seconds(_pf_timeframe_arg)
S_temporary_name_named = timeframe.in_seconds(timeframe = _pf_timeframe_arg)
S_parameter_name_pos = secondsCapturedPos(frameString)
S_parameter_name_named = secondsCapturedNamed(frameString)
S_occupied_escape_pos = timeframe.in_seconds(pf_safe__pf_timeframe_arg)
S_occupied_escape_named = timeframe.in_seconds(timeframe = pf_safe__pf_timeframe_arg)
S_plain_variable_pos = timeframe.in_seconds(plainVariable)
S_plain_variable_named = timeframe.in_seconds(timeframe = plainVariable)
S_persistent_pos = timeframe.in_seconds(persistentFrame)
S_persistent_named = timeframe.in_seconds(timeframe = persistentFrame)
S_return_pos = timeframe.in_seconds(emptyFrame())
S_return_named = timeframe.in_seconds(timeframe = emptyFrame())
S_return_input_pos = timeframe.in_seconds(returnedFrame(frameInput))
S_return_input_named = timeframe.in_seconds(timeframe = returnedFrame(frameInput))
S_period_pos = timeframe.in_seconds(timeframe.period)
S_period_named = timeframe.in_seconds(timeframe = timeframe.period)
S_explicit_pos = timeframe.in_seconds("240")
S_explicit_named = timeframe.in_seconds(timeframe = "240")
S_helper_empty_pos = secondsPos("")
S_helper_explicit_pos = secondsPos("240")
S_helper_empty_named = secondsNamed("")
S_helper_explicit_named = secondsNamed("240")
S_stateful_empty_pos = secondsStatefulPos("")
S_stateful_explicit_pos = secondsStatefulPos("240")
S_stateful_empty_named = secondsStatefulNamed("")
S_stateful_explicit_named = secondsStatefulNamed("240")
S_omitted = timeframe.in_seconds()
C_literal_pos = timeframe.change("") ? 1 : 0
C_literal_named = timeframe.change(timeframe = "") ? 1 : 0
C_input_pos = timeframe.change(frameInput) ? 1 : 0
C_input_named = timeframe.change(timeframe = frameInput) ? 1 : 0
C_string_input_pos = timeframe.change(frameString) ? 1 : 0
C_string_input_named = timeframe.change(timeframe = frameString) ? 1 : 0
C_variable_pos = timeframe.change(frameVariable) ? 1 : 0
C_variable_named = timeframe.change(timeframe = frameVariable) ? 1 : 0
C_temporary_name_pos = timeframe.change(_pf_timeframe_arg) ? 1 : 0
C_temporary_name_named = timeframe.change(timeframe = _pf_timeframe_arg) ? 1 : 0
C_parameter_name_pos = changeCapturedPos(frameString) ? 1 : 0
C_parameter_name_named = changeCapturedNamed(frameString) ? 1 : 0
C_occupied_escape_pos = timeframe.change(pf_safe__pf_timeframe_arg) ? 1 : 0
C_occupied_escape_named = timeframe.change(timeframe = pf_safe__pf_timeframe_arg) ? 1 : 0
C_plain_variable_pos = timeframe.change(plainVariable) ? 1 : 0
C_plain_variable_named = timeframe.change(timeframe = plainVariable) ? 1 : 0
C_persistent_pos = timeframe.change(persistentFrame) ? 1 : 0
C_persistent_named = timeframe.change(timeframe = persistentFrame) ? 1 : 0
C_return_pos = timeframe.change(emptyFrame()) ? 1 : 0
C_return_named = timeframe.change(timeframe = emptyFrame()) ? 1 : 0
C_return_input_pos = timeframe.change(returnedFrame(frameInput)) ? 1 : 0
C_return_input_named = timeframe.change(timeframe = returnedFrame(frameInput)) ? 1 : 0
C_period_pos = timeframe.change(timeframe.period) ? 1 : 0
C_period_named = timeframe.change(timeframe = timeframe.period) ? 1 : 0
C_explicit_pos = timeframe.change("240") ? 1 : 0
C_explicit_named = timeframe.change(timeframe = "240") ? 1 : 0
C_helper_empty_pos = changePos("") ? 1 : 0
C_helper_explicit_pos = changePos("240") ? 1 : 0
C_helper_empty_named = changeNamed("") ? 1 : 0
C_helper_explicit_named = changeNamed("240") ? 1 : 0
C_stateful_empty_pos = changeStatefulPos("") ? 1 : 0
C_stateful_explicit_pos = changeStatefulPos("240") ? 1 : 0
C_stateful_empty_named = changeStatefulNamed("") ? 1 : 0
C_stateful_explicit_named = changeStatefulNamed("240") ? 1 : 0
C_omitted = timeframe.change() ? 1 : 0
dynamicFrame = bar_index % 2 == 0 ? "" : "240"
C_dynamic_pos = timeframe.change(dynamicFrame) ? 1 : 0
C_dynamic_named = timeframe.change(timeframe = dynamicFrame) ? 1 : 0
var calls = array.new_int(1, 0)
C_once_pos = timeframe.change(countedFrame(calls, frameInput)) ? 1 : 0
C_once_named = timeframe.change(timeframe = countedFrame(calls, frameInput)) ? 1 : 0
callCount = array.get(calls, 0)
// @pf-trace S_literal_pos=S_literal_pos
// @pf-trace S_literal_named=S_literal_named
// @pf-trace S_input_pos=S_input_pos
// @pf-trace S_input_named=S_input_named
// @pf-trace S_string_input_pos=S_string_input_pos
// @pf-trace S_string_input_named=S_string_input_named
// @pf-trace S_variable_pos=S_variable_pos
// @pf-trace S_variable_named=S_variable_named
// @pf-trace S_temporary_name_pos=S_temporary_name_pos
// @pf-trace S_temporary_name_named=S_temporary_name_named
// @pf-trace S_parameter_name_pos=S_parameter_name_pos
// @pf-trace S_parameter_name_named=S_parameter_name_named
// @pf-trace S_occupied_escape_pos=S_occupied_escape_pos
// @pf-trace S_occupied_escape_named=S_occupied_escape_named
// @pf-trace S_plain_variable_pos=S_plain_variable_pos
// @pf-trace S_plain_variable_named=S_plain_variable_named
// @pf-trace S_persistent_pos=S_persistent_pos
// @pf-trace S_persistent_named=S_persistent_named
// @pf-trace S_return_pos=S_return_pos
// @pf-trace S_return_named=S_return_named
// @pf-trace S_return_input_pos=S_return_input_pos
// @pf-trace S_return_input_named=S_return_input_named
// @pf-trace S_period_pos=S_period_pos
// @pf-trace S_period_named=S_period_named
// @pf-trace S_explicit_pos=S_explicit_pos
// @pf-trace S_explicit_named=S_explicit_named
// @pf-trace S_helper_empty_pos=S_helper_empty_pos
// @pf-trace S_helper_explicit_pos=S_helper_explicit_pos
// @pf-trace S_helper_empty_named=S_helper_empty_named
// @pf-trace S_helper_explicit_named=S_helper_explicit_named
// @pf-trace S_stateful_empty_pos=S_stateful_empty_pos
// @pf-trace S_stateful_explicit_pos=S_stateful_explicit_pos
// @pf-trace S_stateful_empty_named=S_stateful_empty_named
// @pf-trace S_stateful_explicit_named=S_stateful_explicit_named
// @pf-trace S_omitted=S_omitted
// @pf-trace C_literal_pos=C_literal_pos
// @pf-trace C_literal_named=C_literal_named
// @pf-trace C_input_pos=C_input_pos
// @pf-trace C_input_named=C_input_named
// @pf-trace C_string_input_pos=C_string_input_pos
// @pf-trace C_string_input_named=C_string_input_named
// @pf-trace C_variable_pos=C_variable_pos
// @pf-trace C_variable_named=C_variable_named
// @pf-trace C_temporary_name_pos=C_temporary_name_pos
// @pf-trace C_temporary_name_named=C_temporary_name_named
// @pf-trace C_parameter_name_pos=C_parameter_name_pos
// @pf-trace C_parameter_name_named=C_parameter_name_named
// @pf-trace C_occupied_escape_pos=C_occupied_escape_pos
// @pf-trace C_occupied_escape_named=C_occupied_escape_named
// @pf-trace C_plain_variable_pos=C_plain_variable_pos
// @pf-trace C_plain_variable_named=C_plain_variable_named
// @pf-trace C_persistent_pos=C_persistent_pos
// @pf-trace C_persistent_named=C_persistent_named
// @pf-trace C_return_pos=C_return_pos
// @pf-trace C_return_named=C_return_named
// @pf-trace C_return_input_pos=C_return_input_pos
// @pf-trace C_return_input_named=C_return_input_named
// @pf-trace C_period_pos=C_period_pos
// @pf-trace C_period_named=C_period_named
// @pf-trace C_explicit_pos=C_explicit_pos
// @pf-trace C_explicit_named=C_explicit_named
// @pf-trace C_helper_empty_pos=C_helper_empty_pos
// @pf-trace C_helper_explicit_pos=C_helper_explicit_pos
// @pf-trace C_helper_empty_named=C_helper_empty_named
// @pf-trace C_helper_explicit_named=C_helper_explicit_named
// @pf-trace C_stateful_empty_pos=C_stateful_empty_pos
// @pf-trace C_stateful_explicit_pos=C_stateful_explicit_pos
// @pf-trace C_stateful_empty_named=C_stateful_empty_named
// @pf-trace C_stateful_explicit_named=C_stateful_explicit_named
// @pf-trace C_omitted=C_omitted
// @pf-trace C_dynamic_pos=C_dynamic_pos
// @pf-trace C_dynamic_named=C_dynamic_named
// @pf-trace C_once_pos=C_once_pos
// @pf-trace C_once_named=C_once_named
// @pf-trace callCount=callCount
10 changes: 10 additions & 0 deletions tests/fixtures/empty_timeframe/reporter-change.pine
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
//@version=6
strategy("timeframe.change empty string", overlay = true, initial_capital = 10000)
fast = ta.ema(close, 10)
slow = ta.ema(close, 30)
chg = timeframe.change("") ? 1 : 0
// @pf-trace chg=chg
if ta.crossover(fast, slow)
strategy.entry("Long", strategy.long, qty = 0.01)
if ta.crossunder(fast, slow)
strategy.close("Long")
10 changes: 10 additions & 0 deletions tests/fixtures/empty_timeframe/reporter-seconds.pine
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
//@version=6
strategy("timeframe.in_seconds empty string", overlay = true, initial_capital = 10000)
fast = ta.ema(close, 10)
slow = ta.ema(close, 30)
secs = timeframe.in_seconds("")
// @pf-trace secs=secs
if ta.crossover(fast, slow)
strategy.entry("Long", strategy.long, qty = 0.01)
if ta.crossunder(fast, slow)
strategy.close("Long")
Loading
Loading