tests: tighten coverage by retiring unreachable defensive code#2
Merged
Conversation
Drop the post-NewClient nil guard in startClientLocked. NewClient returns nil only when url == "", and that case is already short-circuited at the top of startClientLocked, so the guard is unreachable. Coverage 99.4% -> 100%.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewClientnil guard instartClientLocked.NewClientreturns nil only whenurl == "", which is already short-circuited at the top of the function, so the guard was dead code.Coverage
Test plan
go test -race -count=1 -timeout 120s ./...passes