fix: use mktemp for health-check temp file instead of world-readable /tmp (PILOT-153)#3
Open
matthew-pilot wants to merge 1 commit into
Open
fix: use mktemp for health-check temp file instead of world-readable /tmp (PILOT-153)#3matthew-pilot wants to merge 1 commit into
matthew-pilot wants to merge 1 commit into
Conversation
…/tmp (PILOT-153) Replace hardcoded /tmp/health-response.json (mode 0666 by default on Linux) with mktemp -t pilot-health.XXXXXX (mode 0600 by default). Prevents information disclosure of node counts, trust statistics, and peer addresses during the deploy health-check window on shared hosts.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PILOT-153:
deploy-rendezvous.shhealth-check wrote sensitive data to/tmp/health-response.jsonwith default mode 0644 (world-readable on Linux).Root Cause
The
health_check()function used a hardcoded path/tmp/health-response.jsonfor curl output. On Linux,/tmpis world-accessible and the file was created with default umask (0644), exposing node counts, trust statistics, and peer addresses to other local users during the deploy window.Fix
Replace the static
/tmp/health-response.jsonpath withmktemp -t pilot-health.XXXXXX, which creates the file with mode 0600 by default. All 4 references updated (curl output, 2× jq reads, 2× cleanup rm).Changes
scripts/deploy-rendezvous.sh— 1 file, +6/-5 linesVerification
go build ./...✅go test ./...✅ (14/14 packages pass)Cc: PILOT-153