daemon: fix silent_for=2562047h overflow log on relay flip (T7)#414
Merged
Conversation
…peers (T7) writeFrame logged 'direct path silent, flipping to relay' with silent_for computed as time.Since(LastDirectRecv(nodeID)); for a peer that never had a direct receive LastDirectRecv returns the zero Time, so time.Since(zero) prints ~292 years (MaxInt64 ns) as 'silent_for=2562047h47m16.854775807s'. Seen 7600x in a single daemon log — misleads log-reading agents/operators. Now: detect the zero case (neverDirect) and render silent_for='never'; the flip itself is correct (a relay-only peer legitimately using relay), only the duration display was garbage. Also truncate to whole seconds for the normal case. Reported as T7 in the pilot-director probe (2026-07-20). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeFramecomputedsilent_forastime.Since(LastDirectRecv); for a never-direct peer that'stime.Since(zero)≈ 292 years, printingsilent_for=2562047h47m16s— 7600× in one daemon log, misleading log-reading agents. Now rendersneverfor the zero case. Found by the pilot-director probe (T7). 🤖 Generated with Claude Code