pilotctl: confine appstore uninstall appID under store root (path traversal)#413
Merged
Merged
Conversation
… traversal) cmdAppStoreUninstall did filepath.Join(root, appID) + RemoveAll without validating appID — 'appstore uninstall --yes ../../something' would RemoveAll outside the install tree. install/verify already guard this via resolveUnder; uninstall now does too. Local-operator-only (no remote trust boundary), but a cheap correctness fix. resolveUnder's existing traversal test (zz_appstore_helpers_test.go) covers the guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
TeoSlayer
force-pushed
the
fix/appstore-uninstall-traversal
branch
from
July 22, 2026 09:19
326fb54 to
c3e46b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appstore uninstall --yes ../../xwould RemoveAll outside the install tree — install/verify already guard via resolveUnder, uninstall didn't. Local-operator-only, cheap fix + test. Found by security sweep. 🤖 Generated with Claude Code