tests: raise libpilot coverage from 0.4% to 5.1%#1
Merged
Conversation
Add 18 internal tests for the only code paths reachable from a go test binary in this c-shared/main package: - handle table (storeHandle/loadHandle/deleteHandle): identity, uniqueness, idempotent delete, concurrent stress for -race - embeddedConfig.defaults(): blank fill, explicit preserve, negative/zero keepalive clamping, registry/beacon format The 45 //export wrappers plus errJSON/okJSON/driverFromHandle/ unmarshalCString carry C.* types in their signatures. Go's test toolchain rejects 'import "C"' in _test.go files for packages that already use //export (use of cgo in test … not supported), so those branches are only reachable from C-side integration tests against the compiled .so.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 18 internal tests covering every code path in this package that is reachable from
go test:storeHandle/loadHandle/deleteHandle): identity round-trip, monotonic IDs, zero-id reservation, idempotent delete, unknown-id no-op, distinct IDs for identical values, two parallel stress tests for-race.embeddedConfig.defaults(): blank-field fill, explicit-value preservation, negative + zeroKeepaliveSecclamping,DataDir/SocketPathleft untouched, registry/beaconhost:portshape check.Coverage delta: 0.4% → 5.1% (per-function: every targeted helper at 100%).
Why coverage didn't reach the 30% target
The 45
//exportwrappers pluserrJSON/okJSON/driverFromHandle/unmarshalCStringall carryC.*types in their signatures. Go's test toolchain refuses to compile_test.gofiles thatimport "C"when the package already declares//exportsymbols:That rules out calling them from Go test code, so their branches can only be reached from C-side integration tests linked against the compiled
.so. Tracked as future work; would need either a separate cgo bridge file (production code change, out of scope here) or a C-language test driver.Test plan
go test -race -count=1 -timeout 120s ./...passes (18 new tests + existing smoke)go vet ./...cleango tool cover -funcshows 100% on every targeted helperbindings.go,embedded.go) modified