Harden CI for new workspace packages#778
Open
necolas wants to merge 2 commits into
Open
Conversation
The build-output artifact and the test job hard-coded package names, so newly added workspace packages were silently excluded from CI: - The artifact listed specific dist dirs and omitted other packages. The lint and typecheck jobs need to download those artifacts. - The test job ran only diffs, trees, and path-store, other package tests never ran. Use `packages/*` globs so any new package is picked up automatically. Run in sequence so CI output is short and readable.
Every job duplicated the Setup Bun + cache + install steps, and the pinned Bun version was repeated per job — the copies had already drifted (1.3.12 for build, 1.3.8 elsewhere) from the 1.3.14 pinned in .prototools. Extract the three steps into a local composite action (.github/actions/setup) that reads the Bun version straight from .prototools, giving the toolchain version a single source of truth shared by proto locally, assert-bun-version on publish, and now every CI job. Each job drops to a checkout plus one `uses: ./.github/actions/setup`, and new jobs get the same cached-deps fast path for free.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10b61f3e8c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI fixes prompted by
@pierre/theme-kit(a new workspace package) breaking lint, typecheck, and builds.Cover all packages in CI, not a hardcoded list.
packages/*/dist/instead of an enumerated subset, so new packages' built types reach the lint/typecheck jobs (theme-kit was missing → types resolved to any).bun ws "packages/*" test --sequentialinstead of a hand-listed three, so new packages' tests actually run.--sequentialkeeps the log ordered and readable;@pierre/truncate(no test files yet) uses--pass-with-no-tests.Single source of truth for the Bun version
.github/actions/setup) that reads the version from.prototools— the same pin proto and assert-bun-version use. Per-job pins had already drifted (1.3.12/1.3.8vs. the pinned1.3.14).uses: ./.github/actions/setup; new jobs get the same cached-deps fast path for free.