Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
bbae805 to
a86c7d3
Compare
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
9fd37f6 to
ed61192
Compare
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
ed61192 to
20570bd
Compare
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
20570bd to
05a72a6
Compare
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
05a72a6 to
837c217
Compare
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
837c217 to
1750c88
Compare
It works, and it definitely shows promise!
This one i think _feels_ a bit better? as it manages to better utilize the window rendering system to only render what's necessary...
Not quite ready yet, since we still need to figure out how to join buffers to appended content...
This should fix the broken buffer regions
* Hovers will be controlled by JS (not yet implemented) * Also fix a bug on selected context elements
This will not fix incomplete or selections that are virtualized... that will take a bit more work... We will need a new API to get line index from a diff/file...
A few important changes here.
* Line indexes when setting a selection should not be based on the DOM
as that's not a valid heuristic for index range to select from
* Added a helper method to determine line indexes programmatically from
the dif
* We should probably do something where we can cache the line index
values onces we've retrieved them for a selection, calling the
function on every render is probably not ideal if it's a large
file...
Basically just use the helper method completely
The logic for partial renders was inverted, oops
* No numbers was a bit broked with the border gap
* Hover effects for lines we jittery when crossing over the 2px
separator between content and gutter
* Had to incorporate that sepeator into the gutter element to avoid
this
Using line number wasn't safe, we need to use lineIndex instead to query for the extra elements
- Given the new nature of the HTML, we have to do hover through JS
- This also gives us the opportunity to improve the api a bit and not
make hover effects on by default
- Also added the ability to hover just the number or just the line if
users want
amadeus
force-pushed
the
amadeus/virtualization-part-2
branch
from
08d1f10 to
951dc80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP