docs: match the README coverage floor to CI - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #44
The README's development commands listed
cargo llvm-cov --workspace --locked --fail-under-lines 89, while CI enforces 94. The README now uses 94, which is also current line coverage (94.79%) rounded down, as the coverage ratchet requires.README.mdand.github/workflows/ci.ymlshows 94 in both, and no other doc names a floorREADME.md:162,.github/workflows/ci.yml:24pickcheck check --base origin/main --fail-on new,worsened,unmatchedon ae9f49aQA: no device pass, because the change is one README line with no code, CLI output, or installer behavior to drive. The manual check above runs the documented command instead.
The release draft is not changed, because this is contributor documentation, not a user-visible change.
Review: independent xhigh reviews by Astra and Fable at ae9f49a found nothing.