More concrete return type for opcache_get_configuration#5424
More concrete return type for opcache_get_configuration#5424devnix wants to merge 1 commit intophpstan:2.1.xfrom
opcache_get_configuration#5424Conversation
|
Not sure such precision is needed ; wasn't https://github.com/phpstan/phpstan-src/pull/5422/changes enough ? |
|
what the real world use-case/motivation for this change? |
|
Expecting a shape, avoiding unnecessary checks of array keys, reporting typos in array keys... |
|
I think we can land the change after we added a separate NodeScopeResolverTest in nsrt/. usually we don't enforce nsrt/ tests for changes in does the suggested return-type array-shape also work for PHP7? |
Array shape based on https://github.com/php/php-src/blob/master/ext/opcache/zend_accelerator_module.c#L800-L904