Skip to content

perf: Cache QueryBuilder class classification #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
realFlowControl wants to merge 2 commits into
base: 2.0.x
Choose a base branch
from
Open

perf: Cache QueryBuilder class classification #778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
395eba2
Cache QueryBuilder class classification
realFlowControl Jul 17, 2026
28fc89d
Merge branch '2.0.x' into optimize/querybuilder-classification-cache
realFlowControl Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Type/Doctrine/QueryBuilder/ReturnQueryBuilderExpressionTypeResolverExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ class ReturnQueryBuilderExpressionTypeResolverExtension implements ExpressionTyp

private OtherMethodQueryBuilderParser $otherMethodQueryBuilderParser;

/** @var array<string, bool> */
private array $queryBuilderClasses = [];

public function __construct(
OtherMethodQueryBuilderParser $otherMethodQueryBuilderParser
)
Expand Down Expand Up @@ -85,7 +88,8 @@ private function getMethodReflection(CallLike $call, Scope $scope): ?MethodRefle
$methodName = $call->name->name;

foreach ($callerType->getObjectClassReflections() as $callerClassReflection) {
if ($callerClassReflection->is(QueryBuilder::class)) {
$className = $callerClassReflection->getName();
if (($this->queryBuilderClasses[$className] ??= $callerClassReflection->is(QueryBuilder::class))) {
return null; // covered by QueryBuilderMethodDynamicReturnTypeExtension

@staabm staabm Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OT: this comment made me curious. looking into QueryBuilderMethodDynamicReturnTypeExtension and
made me realize that we have a config arround to declare what the QueryBuilder class is, since 4d630c6

}
if ($methodName === 'createQueryBuilder' && $callerClassReflection->is(EntityRepository::class)) {
Expand Down
Loading