fix: infer repositories from named managers#757
Open
ItsOtherMauridian wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @ItsOtherMauridian, this feels kinda similar to the already opened by @LubuSeb PR The main discussion #756 (comment) still stands and need a decision first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ManagerRegistryobject-manager loaders when resolving repository metadataManagerRegistry::getRepository($class, $managerName)to resolve metadata from the named managerWhy
When an application has multiple managers that know about the same entity class, the repository type can depend on the explicit manager name passed to
ManagerRegistry::getRepository(). Without considering that argument, PHPStan can infer the repository class from the default manager even when the call explicitly requests another manager.Local validation
Executed in Docker with Composer dependencies installed via:
Validation commands:
Observed results:
Disclosure
This PR was prepared with AI assistance and manually checked before submission.