Repository navigation
Add a Contact Admin feature check - #44
Merged
Merged
Conversation
Checks that a guest sees the contact link in the header and footer navigation and that the contact form loads. On versions with the header/footer link settings, it also saves each combination through the ACP form, checks which links show, and checks that saving changed no other setting. The board is switched to private-message delivery first, since a fresh test board can't send email. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
phpbbmodders/contactadmincheck tophpbb-test-board/feature_checks.py.What it checks
#nav-main) and footer (#nav-footer) navigation, and the contact form loads.feature/nav-link-settings), it saves header off, footer off and both off through the real ACP form. After each save it checks which links show, checks that the form still loads with both off, and checks that saving changed no othercontactadmin_*setting. On older versions that part is skipped and the check says so.The board is switched to private-message delivery first. A fresh test board can't send email, and with email delivery the contact page shows a configuration error and the ACP refuses to save.
The ACP form is submitted with every field as shown on the page (checked radios, text and number inputs, textareas, selected options), with attributes read in any order, so the save changes only the two link settings.
Testing
Claude ran it on a fresh phpBB 3.3 board: 9/9 with Contact Admin's
feature/nav-link-settingsbranch, and 3/3 plus the skip note onmaster.Investigated and written by Claude on behalf of William Jacoby (bonelifer).